From: normalperson@... Date: 2017-10-18T23:37:24+00:00 Subject: [ruby-core:83361] [Ruby trunk Bug#14005][Open] [PATCH] webrick: do not hang acceptor on slow TLS connections Issue #14005 has been updated by normalperson (Eric Wong). Status changed from Closed to Open needs r60211, too :x ---------------------------------------- Bug #14005: [PATCH] webrick: do not hang acceptor on slow TLS connections https://bugs.ruby-lang.org/issues/14005#change-67317 * Author: normalperson (Eric Wong) * Status: Open * Priority: Normal * Assignee: * Target version: * ruby -v: * Backport: 2.3: REQUIRED, 2.4: REQUIRED ---------------------------------------- OpenSSL::SSL::SSLSocket#accept may block indefinitely on clients which negotiate the TCP connection, but fail (or are slow) to negotiate the subsequent TLS handshake. This prevents the multi-threaded WEBrick server from accepting other connections. Since the TLS handshake (via OpenSSL::SSL::SSLSocket#accept) consists of normal read/write traffic over TCP, handle it in the per-client thread, instead. Furthermore, using non-blocking accept() is useful for non-TLS sockets anyways because spurious wakeups are possible from select(2). * lib/webrick/server.rb (accept_client): use TCPServer#accept_nonblock and remove OpenSSL::SSL::SSLSocket#accept call * lib/webrick/server.rb (start_thread): call OpenSSL::SSL::SSLSocket#accept * test/webrick/test_ssl_server.rb (test_slow_connect): new test ---Files-------------------------------- 0001-webrick-do-not-hang-acceptor-on-slow-TLS-connections.patch (4.12 KB) -- https://bugs.ruby-lang.org/ Unsubscribe: