[ruby-core:83252] [Ruby trunk Bug#14011] Appveyor failure - svn 60172 - ‘webrick: do not hang acceptor on slow TLS connections’

Issue #14011 has been updated by MSP-Greg (Greg L).


normalperson (Eric Wong) wrote:

>  OK, so the puma failures are independent of my webrick change
>  (r60172), correct?   Also, keep in mind puma uses it's own
>  "minissl" C extension which could introduce more variables.

Yes.  They happened before your commit.  I mentioned them just because 'nonblock' in ruby std-lib code seems common to both...

>  
>  But the ECONNRESET failure in
>  TestNetHTTPS#test_certificate_verify_failure is new and probably
>  the result of my webrick change?

Yes.  It's failing both on the Appveyor mswin build and my local MinGW build.

>  Does it still happen if you remove the WEBRick::Utils.timeout
>  call I added and just call `sock.accept'?

I've think you're referring to:

```ruby
if sock.respond_to?(:sync_close=) && @config[:SSLStartImmediately]
  WEBrick::Utils.timeout(@config[:RequestTimeout]) do
    sock.accept # OpenSSL::SSL::SSLSocket#accept
  end
end
```

Commented out 2 & 4 (start from 1), still have the failure, then commented out all but 3, still the failure.

>  Hopefully this gets figured out soon or usa or someone else
>  can chime in.  I'll be offline for a few days soonish.

Offline is good sometimes...  Thanks.

----------------------------------------
Bug #14011: Appveyor failure - svn 60172 - ‘webrick: do not hang acceptor on slow TLS connections’
https://bugs.ruby-lang.org/issues/14011#change-67208

* Author: MSP-Greg (Greg L)
* Status: Open
* Priority: Normal
* Assignee: 
* Target version: 
* ruby -v: ruby 2.5.0dev (2017-10-12 trunk 60170) [x64-mingw32]
* Backport: 2.3: UNKNOWN, 2.4: UNKNOWN
----------------------------------------
I noticed the recent [Appveyor failure]( https://ci.appveyor.com/project/ruby/ruby/build/1.0.5475#L4546) from [‘webrick: do not hang acceptor on slow TLS connections’ svn 60172]( https://github.com/ruby/ruby/commit/feafe07874d3f9f9aa3fa007421ecd28472959a7).

Coincidentally, I recently tried a MinGW build with the gem puma using SSL.  It builds fine with ruby 2.2 thru trunk, but also has several [Appveyor failures]( https://ci.appveyor.com/project/MSP-Greg/puma) similar to the above, as all involve SSL servers and nonblock connections.

I’m happy to help with testing, but I suspect this is beyond my current knowledge in terms of a fix…

FYI, I did run up puma locally with a static rack, http, and trunk; everything works fine.  I did not write code to connect it with multiple concurrent clients (I’ve done that before back when I was coding in C#).  I also understand that some things may ‘just not work’ on windows.

Thanks again, Greg


---Files--------------------------------
trunk_mswin_webrick.txt (556 Bytes)
trunk_mingw_puma.txt (6.47 KB)


-- 
https://bugs.ruby-lang.org/

Unsubscribe: <mailto:[e-mail]?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>