Re: [OT] Rant about keyword logical operators was : (Re: [ ruby-Bugs-3843 ] "not" operator used in expression that is a method parameter can generate syntax error)

Hello,

On Thu, 16 Mar 2006 20:59:40 +0900, Nikolai Weibull <[e-mail]> wrote:

> On 3/16/06, Zev Blut <[e-mail]> wrote:
>> Thus if I write some code such as:
>>
>> "if foo && bar"
>>
>> Then a coworker cannot come and change that line to:
>>
>> "if foo and bar"
>
> I'm probably missing something vital here, but why would changing it
> be a problem?


I am embarrassed to say, but in the past we have had situations where
one developer will change the style and commit it to CVS and another
developer will at some later time change the style back to the
original expression and commit it.  In this case and in the case where
a developer simply changes the style once, it makes tracing the
history of who wrote the line of code and why more difficult.

Unfortunately, my team is split about 50/50 on which style to use and
I want to save my stylistic veto rights for more important issues.  So
for now we have an agreement that you keep the original style of the
code, unless you are fixing a bug or making a bigger change to that
line.  I know that this is silly, but I guess this is what happens
when you do not create coding guidelines from the beginning of a
project and the programming language you use gives you more than one
way to write logical operators.

Cheers,
Zev