[ruby-core:62756] test failure from zzak:r46123 (trunk): * lib/csv.rb: Reject nil as data source for CSV.new, patch by @Peeja.

From: Eric Wong <normalperson@...>
Date: 2014-05-25 23:35:11 UTC
List: ruby-core #62756
zzak@ruby-lang.org wrote:
>   http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=rev&revision=46123
> 
>   Log:
>     * lib/csv.rb: Reject nil as data source for CSV.new, patch by @Peeja.
>       [Fixes GH-580] https://github.com/ruby/ruby/pull/580

Hi Zach, I get the following failures from test-all after r46123.
These do not fail when r46123 is reverted.

  6) Failure:
TestCSV::Features#test_accepts_comment_skip_lines_option [/home/ew/ruby/test/csv/test_features.rb:285]:
Exception raised:
<#<ArgumentError: Cannot parse nil as CSV>>.

  7) Failure:
TestCSV::Features::DifferentOFS#test_accepts_comment_skip_lines_option [/home/ew/ruby/test/csv/test_features.rb:285]:
Exception raised:
<#<ArgumentError: Cannot parse nil as CSV>>.

  8) Error:
TestCSV::Features#test_accepts_comment_defaults_to_nil:
ArgumentError: Cannot parse nil as CSV
    /home/ew/ruby/lib/csv.rb:1488:in `initialize'
    /home/ew/ruby/test/csv/test_features.rb:291:in `new'
    /home/ew/ruby/test/csv/test_features.rb:291:in `test_accepts_comment_defaults_to_nil'

  9) Error:
TestCSV::Features::DifferentOFS#test_accepts_comment_defaults_to_nil:
ArgumentError: Cannot parse nil as CSV
    /home/ew/ruby/lib/csv.rb:1488:in `initialize'
    /home/ew/ruby/test/csv/test_features.rb:291:in `new'
    /home/ew/ruby/test/csv/test_features.rb:291:in `test_accepts_comment_defaults_to_nil'

15397 tests, 2781866 assertions, 2 failures, 2 errors, 66 skips

ruby -v: ruby 2.2.0dev (2014-05-26 trunk 46123) [x86_64-linux]
make: *** [yes-test-all] Error 4

In This Thread

Prev Next