[ruby-core:62443] [ruby-trunk - Bug #9677] OpenSSL::PKey::EC#to_text causes a segmentation fault

Issue #9677 has been updated by Heesob Park.


I found that the segmentation fault occurs when a public_key is not set.
Here is a patch.

~~~
diff --git a/ossl_pkey_ec.c b/ossl_pkey_ec.c
index 5e419bd..070bfc4 100644
--- a/ossl_pkey_ec.c
+++ b/ossl_pkey_ec.c
@@ -574,6 +574,13 @@ static VALUE ossl_ec_key_to_text(VALUE self)
     VALUE str;
 
     Require_EC_KEY(self, ec);
+
+    if (EC_KEY_get0_public_key(ec) == NULL)
+        ossl_raise(eECError, "can't export - no public key set");
+
+    if (EC_KEY_check_key(ec) != 1)
+        ossl_raise(eECError, "can't export - EC_KEY_check_key failed");
+    
     if (!(out = BIO_new(BIO_s_mem()))) {
         ossl_raise(eECError, "BIO_new(BIO_s_mem())");
     }
~~~

----------------------------------------
Bug #9677: OpenSSL::PKey::EC#to_text causes a segmentation fault
https://bugs.ruby-lang.org/issues/9677#change-46590

* Author: David Grayson
* Status: Open
* Priority: Normal
* Assignee: Martin Bosslet
* Category: ext/openssl
* Target version: 
* ruby -v: ruby 2.1.1p76 (2014-02-24 revision 45161) [x86_64-linux]
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN
----------------------------------------
I have Ruby 2.1.1p76 and when I try to run a particular snippet of code using the OpenSSL extension, I get a segmentation fault.  I am running Arch Linux and I have openssl 1.0.1.f-1.  I built Ruby from source.  This bug also affects Ruby 2.1.0.

Here is a snippet of shell output showing the Ruby command that causes the problem:

~~~
$ ruby -v -ropenssl -e "OpenSSL::PKey::EC.new('secp256k1').to_text"
ruby 2.1.1p76 (2014-02-24 revision 45161) [x86_64-linux]
-e:1: [BUG] Segmentation fault at 0x00000000000000
...
~~~

I attached a text file with the full output from Ruby to this bug report.

This other OpenSSL segmentation fault issue might be related:

https://bugs.ruby-lang.org/issues/9592

---Files--------------------------------
openssl_to_text_segfault.txt (15.7 KB)


-- 
https://bugs.ruby-lang.org/