From: nobu@...
Date: 2014-05-04T08:06:39+00:00
Subject: [ruby-core:62343] [ruby-trunk - Bug #9794] DateTime.strptime() doesn't work correctly for '%s %z'

Issue #9794 has been updated by Nobuyoshi Nakada.


It doesn't seem there is absolute reason that you have to use `Time.strptime`.
Particular methods feel more suitable, like rfc2822, httpdate, and xml.

~~~ruby
class Time
  def self.git(s)
    /\A(\d+)\s+([-+]\d\d)(\d\d)\z/ =~ s or
      raise ArgumentError, "invalid git timestamp: #{s}"
    at($1.to_i).getlocal("#$2:#$3")
  end
  def git
    strftime("%s %z")
  end
end
~~~

----------------------------------------
Bug #9794: DateTime.strptime() doesn't work correctly for '%s %z'
https://bugs.ruby-lang.org/issues/9794#change-46499

* Author: Felipe Contreras
* Status: Rejected
* Priority: Low
* Assignee: tadayoshi funaba
* Category: ext
* Target version: 
* ruby -v: 2.1.1p76
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN
----------------------------------------
Time.strptime() works correctly:

    Time.strptime('0 +0100', '%s %z').strftime('%s %z')
    => "0 +0100"

But DateTime.strptime() doesn't:

    DateTime.strptime('0 +0100', '%s %z').strftime('%s %z')
    => "0 +0000"

In Rubinious it does work correctly:

    DateTime.strptime('0 +0100', '%s %z').strftime('%s %z')
    => "0 +0100"

This make the RubySL date space fail:

    DateTime#strptime parses seconds and timezone correctly FAILED
    Expected "1970-01-01T00:00:00+00:00"
     to equal "1970-01-01T01:00:00+01:00"

In addition, both C and perl preserver the offset correctly when doing '%s %z'.

So it's very clear DateTime.strptime() has to be fixed.

Patch attached.

---Files--------------------------------
0001-datetime-fix-strptime-s-z.patch (1.94 KB)


-- 
https://bugs.ruby-lang.org/