From: nornagon <nornagon@...>
Date: 2005-07-30T21:35:59+09:00
Subject: Re: Observer patch

On 7/9/05, Hugh Sasse <hgs@dmu.ac.uk> wrote:
> On Fri, 8 Jul 2005, nornagon wrote:
> >
> > [snip]
> >
> >  # Add +observer+ as an observer on this object. +observer+ will now receive
> >  # notifications.
> 
> You've changed how this is called.  IMHO you should patch the
> leading RDOC comment.
> 
> >  [snip]
> > +    @observer_peers = {} unless defined? @observer_peers
> 
> is
> 
>         @observer_peers ||= {}
> 
> more idiomatic?   Performance??
> 
> > [snip]
> > +       @observer_peers.each { |k, v|
> > +      k.send v, *arg
> > +    }
> 
> if nitpick.allowed? -- aren't we moving towards having {} for
> one-liners and do...end for multi-line blocks?  Giving 2 possible
> patches for this patch :-)

I won't bother applying those changes unless this is going to go into
the core -- which I believe it should; it's a trivial patch that adds
a lot of flexibility to Observable.

If it is going to go into the core, I'll just add those changes and
repost the patch, unless someone does it before I do. :)

-- 
- nornagon