From: Tilman Sauerbeck <tilman@...>
Date: 2005-02-11T03:00:01+09:00
Subject: [PATCH] RDoc - show protected methods by default

--fdj2RfSjLxBAspz7
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Hi,
atm, RDoc will only show/document protected methods if the "-all" switch
is set.

IMHO it makes sense to include protected methods by default, too, since
these belong to the visible API as well :)

See the attached patch.

-- 
Regards,
Tilman

--fdj2RfSjLxBAspz7
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="rdoc-show_protected_by_default.diff"

diff -aur ruby-1.8.2.orig/lib/rdoc/generators/html_generator.rb ruby-1.8.2/lib/rdoc/generators/html_generator.rb
--- ruby-1.8.2.orig/lib/rdoc/generators/html_generator.rb	2004-11-20 16:02:56.000000000 +0100
+++ ruby-1.8.2/lib/rdoc/generators/html_generator.rb	2005-02-10 18:54:13.437547072 +0100
@@ -314,7 +314,7 @@
     def collect_methods
       list = @context.method_list
       unless @options.show_all
-        list = list.find_all {|m| m.visibility == :public || m.force_documentation }
+        list = list.find_all {|m| m.visibility == :public || m.visibility == :protected || m.force_documentation }
       end
       @methods = list.collect {|m| HtmlMethod.new(m, self, @options) }
     end
@@ -681,13 +681,13 @@
       res = []
       atts.each do |att|
         next unless att.section == section
-        if att.visibility == :public || @options.show_all
+        if att.visibility == :public || att.visibility == :protected || @options.show_all
           entry = {
             "name"   => CGI.escapeHTML(att.name), 
             "rw"     => att.rw, 
             "a_desc" => markup(att.comment, true)
           }
-          unless att.visibility == :public
+          unless att.visibility == :public || att.visibility == :protected
             entry["rw"] << "-"
           end
           res << entry
diff -aur ruby-1.8.2.orig/lib/rdoc/generators/ri_generator.rb ruby-1.8.2/lib/rdoc/generators/ri_generator.rb
--- ruby-1.8.2.orig/lib/rdoc/generators/ri_generator.rb	2004-01-02 07:01:12.000000000 +0100
+++ ruby-1.8.2/lib/rdoc/generators/ri_generator.rb	2005-02-10 18:51:35.631537232 +0100
@@ -172,7 +172,7 @@
       list = cls.method_list
       unless @options.show_all
         list = list.find_all do |m|
-          m.visibility == :public || m.force_documentation 
+          m.visibility == :public || m.visibility == :protected || m.force_documentation
         end
       end
 

--fdj2RfSjLxBAspz7--