From: Luis Lavena <luislavena@...>
Date: 2011-12-24T23:46:33+09:00
Subject: [ruby-core:41795] Re: [ruby-changes:22069] luislavena:r34118 (trunk): * configure.in: add --with-ntver option to match win32/configure.bat

On Sat, Dec 24, 2011 at 11:41 AM, KOSAKI Motohiro
<kosaki.motohiro@gmail.com> wrote:
> Hi Luis,
>

Hello,

>
> ===================================================================
>> --- configure.in � � � �(revision 34117)
>> +++ configure.in � � � �(revision 34118)
>> @@ -940,7 +940,15 @@
>> � � � �AS_HELP_STRING([--enable-win95], [enable Windows 95 series support]),
>> � [AS_CASE(["$enableval"],[yes|no],[enable_win95=$enableval],[unset enable_win95])])
>>
>> +AC_ARG_WITH(ntver,
>> + �AS_HELP_STRING([--with-ntver=0xXXXX], [target NT version (default to 0x0501)]),
>> + �[with_ntver="$withval"], [with_ntver="0x0501"])
>> �AS_CASE(["$target_os"],
>> +[mingw*], [
>> + �RUBY_APPEND_OPTION(CPPFLAGS, -D_WIN32_WINNT=$with_ntver)
>> +])
>
> Could you please consider to rename this with --with-win-ntver or
> --with-mingw-ntver or similar?
> Under win32 directory, the meaning of 'ntver' is very clear to me. but
> it doesn't have OS independent meanings and 'nt' is too short word.
>
> OK, help strings help us and you did. but I think clear name also help us.
>

OK, I followed the same description and flag from win32/configure.bat
to keep it consistent.

I think --with-winnt-ver might sounds more appropriate?

Also, I can adjust the description to "target Windows NT version" so
is more clear that NT is Windows :-)

===
diff --git a/configure.in b/configure.in
index 9615c60..b9f3c79 100644
--- a/configure.in
+++ b/configure.in
@@ -940,12 +940,12 @@ AC_ARG_ENABLE(win95,
 	AS_HELP_STRING([--enable-win95], [enable Windows 95 series support]),
   [AS_CASE(["$enableval"],[yes|no],[enable_win95=$enableval],[unset
enable_win95])])

-AC_ARG_WITH(ntver,
-  AS_HELP_STRING([--with-ntver=0xXXXX], [target NT version (default
to 0x0501)]),
-  [with_ntver="$withval"], [with_ntver="0x0501"])
+AC_ARG_WITH(winnt-ver,
+  AS_HELP_STRING([--with-winnt-ver=0xXXXX], [target Windows NT
version (default to 0x0501)]),
+  [with_winnt_ver="$withval"], [with_winnt_ver="0x0501"])
 AS_CASE(["$target_os"],
 [mingw*], [
-  RUBY_APPEND_OPTION(CPPFLAGS, -D_WIN32_WINNT=$with_ntver)
+  RUBY_APPEND_OPTION(CPPFLAGS, -D_WIN32_WINNT=$with_winnt_ver)
 ])

 AS_CASE(["$target_os"],
===

Looks better?

-- 
Luis Lavena
AREA 17
-
Perfection in design is achieved not when there is nothing more to add,
but rather when there is nothing more to take away.
Antoine de Saint-Exup�ry