[ruby-core:41536] Re: [ruby-trunk - Bug #5714] Unexpected error of STDIN#read with non-ascii input on Windows XP

Hi,

2011/12/7 Hiroshi Shirosaki <[e-mail]>
>
> >
> > - =C2=A0 =C2=A0if (_osfile(fd) & FTEXT) {
> > + =C2=A0 =C2=A0isconsole =3D is_console(_osfhnd(fd));
> > + =C2=A0 =C2=A0if (!isconsole && (_osfile(fd) & FTEXT)) {
> > =C2=A0 =C2=A0 =C2=A0 =C2=A0return _read(fd, buf, size);
> > =C2=A0 =C2=A0 }
> >
>
> I intended STDIN doesn't use text mode at #5562 patch. So STDIN
> doesn't need to use _read().
> I thought (_osfile(fd) & FTEXT) should be false in the case of STDIN.
>

I found that the initial value of _osfile(STDIN) is 0xC1 and same for
_osfile(STDOUT) and _osfile(STDERR).
The value 0xC1 means  (FTEXT | FDEV | FOPEN).

Here is another patch for

diff --git a/win32.c b/win32.c.new
index 67a392e..db9e222 100644
--- a/win32.c
+++ b/win32.c.new
@@ -2259,12 +2259,21 @@ init_stdhandle(void)
     if (fileno(stdin) < 0) {
 	stdin->_file =3D open_null(0);
     }
+    else {
+	setmode(fileno(stdin), O_BINARY); //  _osfile(fileno(stdin)) &=3D ~FTEXT;
+    }
     if (fileno(stdout) < 0) {
 	stdout->_file =3D open_null(1);
     }
+    else {
+	setmode(fileno(stdout), O_BINARY); //   _osfile(fileno(stdout)) &=3D ~FTE=
XT;
+    }
     if (fileno(stderr) < 0) {
 	stderr->_file =3D open_null(2);
     }
+    else {
+	setmode(fileno(stderr), O_BINARY); //   _osfile(fileno(stderr)) &=3D ~FTE=
XT;
+    }
     if (nullfd >=3D 0 && !keep) close(nullfd);
     setvbuf(stderr, NULL, _IONBF, 0);
 }

Regards,
Park Heesob