From: Eric Wong <normalperson@...>
Date: 2012-02-26T07:34:03+09:00
Subject: [ruby-core:42943] Re: [ruby-trunk - Bug #5765] [PATCH] modernize Timeout usage in net/{http,pop,smtp,telnet}

Eric Hodel <drbrain@segment7.net> wrote:
> I like this patch.
> 
> This patch will collide with #6001, though, since I introduce
> Net::HTTP::OpenTimeout as a subclass of Timeout::Error.  Should we add
> Net::OpenTimeout instead of Net::HTTP::OpenTimeout?

Yes, I vastly prefer Net::OpenTimeout since timeouts shouldn't be
limited to HTTP.

> See also #6088 where I introduce Net::ReadTimeout.  The division
> between Net::ReadTimeout and Net::OpenTimeout will allow users to
> distinguish which operation timed out.  For a read timeout they may
> wish to retry the operation.

Excellent.  Your net.modernize_timeout_usage.open_timeout.patch looks
good to me.  Thanks!