From: Benoit Daloze Date: 2012-01-03T04:55:39+09:00 Subject: [ruby-core:41872] [ruby-trunk - Feature #5809][Open] Benchmark#bm: remove the label_width parameter --00235447108864411204b590f77f Content-Type: text/plain; charset=ISO-8859-1 Yui NARUSE wrote: > If your suggestion is to provide easy way to pretty enough benchmark method, how about following: Nice! That could be a new and concise way to do benchmarks (although it might be less flexible). My suggestion is to improve Benchmark#benchmark (and so #bm) by removing the label_width argument, which I think is unnecessary (and so calculate it). I would keep compatibility (use the width if given), but remove the feature of returning the time directly at #report, which is not done for #bmbm anyway. Do you think it is fine to remove that (as far as I know) unused feature? Or should I absolutely keep it (although it is inconsistent and duplicate the code) ? --00235447108864411204b590f77f Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Yui NARUSE wrote:
> If your suggestion is to provide easy way to pretty enough benchmark m= ethod, how about following:

Nice! That could be a new and concise way to do benchmarks (although it mig= ht be less flexible).

My suggestion is to improve Benchmark#benchmark (and so #bm) by removing th= e label_width argument, which I think is unnecessary (and so calculate it).=

I would keep compatibility (use the width if given), but remove the feature= of returning the time directly at #report, which is not done for #bmbm any= way.

Do you think it is fine to remove that (as far as I know) unuse= d feature? Or should I absolutely keep it (although it is inconsistent and = duplicate the code) ?
--00235447108864411204b590f77f--