[ruby-core:41507] [Backport93 - Backport #5704] Please backport r33937

Issue #5704 has been updated by Jon Forums.


FYI, in the hope that it helps with backporting, a branch containing Hiroshi's patch is being maintained at

https://github.com/thecodeshop/ruby/commits/winio/ruby_1_9_3/

The branch also contains backports of r33200 and r33662 so that the following tests pass when building with the RubyInstaller build recipes on Win7 32bit SP1:

make test-all TESTS='openssl fiddle psych zlib io ruby/test_io.rb ruby/test_io_m17n.rb ruby/test_file.rb'
make test
----------------------------------------
Backport #5704: Please backport r33937
http://redmine.ruby-lang.org/issues/5704

Author: Luis Lavena
Status: Open
Priority: Normal
Assignee: Yuki Sonoda
Category: 
Target version: 


Hello,

r33937 contains what was labeled 'feature' for ruby-trunk (Issue #5562), however, it was considered a bug and acknowledged by developers in #1332

Quoting Yusuke Endoh:

"Yes, text mode is still 10x -- 30x slower than binary mode.
It is reproduced not only on windows but also Linux.
Perhaps, this is the symptom because of the reason explained
in [ruby-core:26515]."

And quoting Usaku Nakamura:

"Currently, we has implemented the newline conversion as a
transcode converter, just like encoding conversion.
But the design of transcode is too general to use it such
a simple operation, as our finding.
We want to find a better mechanism which doesn't deviate
from the current design of IO..."

The patch provided by Hiroshi Shirosaki speeds up both file read and write operations under Windows to decent levels while do not deviate from current IO design.

Please consider this for backporting as we see it as Bug and not Feature.


-- 
http://redmine.ruby-lang.org