[ruby-core:28244] Re: [Bug:1.8]weird behaviour of readline on OSX 10.6

Hi

I tried that patch and it works on 10.6. My ruby version:

ruby 1.8.7 (2009-06-12 patchlevel 174) [i686-darwin10.2.0]

-andrew

On Thu, Feb 18, 2010 at 3:36 PM, NARUSE, Yui <[e-mail]> wrote:
> Hi,
>
> You seems to use Ruby 1.8.x.
> So can you try following?
>
> Index: ext/readline/readline.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- ext/readline/readline.c =A0 =A0 (revision 26664)
> +++ ext/readline/readline.c =A0 =A0 (working copy)
> @@ -833,6 +833,12 @@
> =A0#ifdef HAVE_RL_EVENT_HOOK
> =A0 =A0 rl_event_hook =3D readline_event;
> =A0#endif
> +#ifdef HAVE_RL_CATCH_SIGNALS
> + =A0 =A0rl_catch_signals =3D 0;
> +#endif
> +#ifdef HAVE_RL_CATCH_SIGWINCH
> + =A0 =A0rl_catch_sigwinch =3D 0;
> +#endif
> =A0#ifdef HAVE_RL_CLEAR_SIGNALS
> =A0 =A0 rl_clear_signals();
> =A0#endif
> Index: ext/readline/extconf.rb
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- ext/readline/extconf.rb =A0 =A0 (revision 26664)
> +++ ext/readline/extconf.rb =A0 =A0 (working copy)
> @@ -59,6 +59,9 @@
> =A0have_readline_var("rl_attempted_completion_over")
> =A0have_readline_var("rl_library_version")
> =A0have_readline_var("rl_event_hook")
> +# workaround for native windows.
> +/mswin|bccwin|mingw/ !~ RUBY_PLATFORM && have_readline_var("rl_catch_sig=
winch")
> +/mswin|bccwin|mingw/ !~ RUBY_PLATFORM && have_readline_var("rl_catch_sig=
nals")
> =A0have_readline_func("rl_cleanup_after_signal")
> =A0have_readline_func("rl_clear_signals")
> =A0have_readline_func("rl_vi_editing_mode")
>
> (2010/02/19 4:59), Andrew Eberbach wrote:
>> Hi
>>
>> I've been noticing that irb (and as a result script/console in rails)
>> don't behave correctly with Control C. Nothing would happen when I hit
>> control C until I hit enter or a few more keys and then it would clear
>> the line and show a ^C and reset to the prompt. This doesn't happen on
>> Linux and it didn't happen on 10.5
>>
>> If there's a long running process in irb hitting control c works as
>> expected but not if it's just sitting at a prompt.
>>
>> I played around with the ext/readline.c and found that if I put a
>>
>> =A0rl_catch_signals =3D 0;
>>
>> (see http://tiswww.case.edu/php/chet/readline/readline.html)
>>
>> in Init_readline()
>>
>> Then everything works as normal. Should this be added as a patch?
>> Reading the readline docs it seems to me that what's happening is the
>> internal readline handler gets stuck sending SIGINT back to the ruby
>> process even though there's a trap("SIGINT") defined. Any ideas?
>>
>>
>> Andrew
>>
>
> --
> NARUSE, Yui =A0<[e-mail]>
>
>