From: eregontp@...
Date: 2020-12-21T10:47:05+00:00
Subject: [ruby-core:101580] [Ruby master Feature#16697] Hash.ruby2_keywords_hash?(value) should support any object

Issue #16697 has been updated by Eregon (Benoit Daloze).

Status changed from Feedback to Closed

OK, let's reject this then.

----------------------------------------
Feature #16697: Hash.ruby2_keywords_hash?(value) should support any object
https://bugs.ruby-lang.org/issues/16697#change-89365

* Author: Eregon (Benoit Daloze)
* Status: Closed
* Priority: Normal
----------------------------------------
But currently it raises, which makes it needlessly inconvenient to use:
```ruby
> Hash.ruby2_keywords_hash?({})
=> false
> Hash.ruby2_keywords_hash?("hello")
Traceback (most recent call last):
        5: from /home/eregon/.rubies/ruby-trunk/bin/irb:23:in `<main>'
        4: from /home/eregon/.rubies/ruby-trunk/bin/irb:23:in `load'
        3: from /home/eregon/prefix/ruby-trunk/lib/ruby/gems/2.8.0/gems/irb-1.2.3/exe/irb:11:in `<top (required)>'
        2: from (irb):4
        1: from (irb):4:in `ruby2_keywords_hash?'
TypeError (wrong argument type String (expected Hash))
```

See https://github.com/ruby/ruby/pull/2966/files#r394741112 for a motivating example.

I'd like to suggest backporting this to 2.7 too.



-- 
https://bugs.ruby-lang.org/

Unsubscribe: <mailto:ruby-core-request@ruby-lang.org?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>