[ruby-core:101354] [Ruby master Feature#16697] Hash.ruby2_keywords_hash?(value) should support any object

Issue #16697 has been updated by mame (Yusuke Endoh).


I'm a bit afraid if changing the behavior would bring confusion rather than trivial usability. It is easy to workaround the issue. 

Anyway, if it is changed, we need to backport the patch to ruby_2_7. If ruby_2_7 and master are inconsistent, it is more confusing. @nagachika -san, will you backport it if it is accepted?

----------------------------------------
Feature #16697: Hash.ruby2_keywords_hash?(value) should support any object
https://bugs.ruby-lang.org/issues/16697#change-89060

* Author: Eregon (Benoit Daloze)
* Status: Open
* Priority: Normal
* Target version: 3.0
----------------------------------------
But currently it raises, which makes it needlessly inconvenient to use:
```ruby
> Hash.ruby2_keywords_hash?({})
=> false
> Hash.ruby2_keywords_hash?("hello")
Traceback (most recent call last):
        5: from /home/eregon/.rubies/ruby-trunk/bin/irb:23:in `<main>'
        4: from /home/eregon/.rubies/ruby-trunk/bin/irb:23:in `load'
        3: from /home/eregon/prefix/ruby-trunk/lib/ruby/gems/2.8.0/gems/irb-1.2.3/exe/irb:11:in `<top (required)>'
        2: from (irb):4
        1: from (irb):4:in `ruby2_keywords_hash?'
TypeError (wrong argument type String (expected Hash))
```

See https://github.com/ruby/ruby/pull/2966/files#r394741112 for a motivating example.

I'd like to suggest backporting this to 2.7 too.



-- 
https://bugs.ruby-lang.org/

Unsubscribe: <mailto:[e-mail]?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>