[ruby-core:98795] [Ruby master Bug#16941] MJIT doesn't identify Struct kind of instruction

Issue #16941 has been updated by abhsha (Abhishek Sharma).


Hi k0kubun,
I think it should be Ok for me with --jit-min-calls=10000. Also, I will take the struct declaration outside of the block, so it shouldn't be a problem anymore for my case.

Thanks for all the help. With this ticket I developed an interest in Ruby internals and moving forward, I would like to contribute to the community. I have written a separate email to you to further our discussion as it is beyond the scope of this ticket. :)

Thanks,
Abhishek

----------------------------------------
Bug #16941: MJIT doesn't identify Struct kind of instruction
https://bugs.ruby-lang.org/issues/16941#change-86156

* Author: abhsha (Abhishek Sharma)
* Status: Feedback
* Priority: Normal
* Assignee: k0kubun (Takashi Kokubun)
* ruby -v: 2.6.0p0 (2018-12-25 revision 66547) [x86_64-linux]
* Backport: 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN
----------------------------------------
MJIT does not identify Struct instructions and gives a warning while compiling to C.

Example: 
def my_method
    1.times do
        a_struct = Struct.new(:a).new
        a_struct.a = "a"
    end
end

my_method

$: ruby --jit-save-temps --jit-min-calls=1 --disable-gems --jit --jit-verbose=2 --jit-wait test.rb

output:
start compilation: a=@test.rb:3 -> /tmp/_ruby_mjit_p30696u2.c
MJIT warning: Skipped to compile unsupported instruction: opt_call_c_function
JIT failure (0.0ms): a=@test.rb:3 -> /tmp/_ruby_mjit_p30696u2.c

Are structs not recognised by JIT compiler? 
We have this call in our programs many number of times (~ 10^6), it attempts every time and fails. Can this be a cause of programs to get slower with --jit enabled ? 



-- 
https://bugs.ruby-lang.org/

Unsubscribe: <mailto:[e-mail]?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>