From: samuel@... Date: 2021-04-29T00:21:46+00:00 Subject: [ruby-core:103650] [Ruby master Feature#16962] Make IO.for_fd autoclose option default to false Issue #16962 has been updated by ioquatix (Samuel Williams). Thanks for looking into this. Not being able to close some file descriptors when using `IO.for_fd` is almost certainly a bug. ``` /* need to keep FILE objects of stdin, stdout and stderr */ ``` Why? ---------------------------------------- Feature #16962: Make IO.for_fd autoclose option default to false https://bugs.ruby-lang.org/issues/16962#change-91746 * Author: ioquatix (Samuel Williams) * Status: Open * Priority: Normal ---------------------------------------- I discussed this with @eregon and I think the goal here is to try and figure out a way these interfaces can be a bit less confusing. ## 1. I don't understand this behaviour: ```ruby STDOUT.close STDOUT.puts "Hello World" # => closed stream ``` vs ```ruby IO.for_fd(STDOUT.fileno, autoclose: true).close STDOUT.puts "Hello World" # => Hello World ``` ## 2. `IO.for_fd(..., autoclose: true/false)` The documentation for `autoclose` is: > If the value is false, the fd will be kept open after this IO instance gets finalized. But it also seems to affect `#close` - i.e. calling close does not close underlying file descriptor. Should we fix the documentation or is the implementation wrong? Maybe the name `autoclose:` is very confusing. My initial interpretation was it was just 'automatically close this I/O when it is garbage collected'. ## 3. `IO.for_fd(..., autoclose: false)` default In most cases, it seems like `autoclose: false` would make more sense as the default, since the file descriptor must come from some other place. -- https://bugs.ruby-lang.org/ Unsubscribe: