From: kou@...
Date: 2021-04-20T02:07:46+00:00
Subject: [ruby-core:103517] [Ruby master Bug#11579] Fiddle.win32_last_error after calling Fiddle::Function#call isn't GetLastError()

Issue #11579 has been updated by kou (Kouhei Sutou).

Assignee changed from tenderlovemaking (Aaron Patterson) to kou (Kouhei Sutou)
Status changed from Open to Closed

Thanks. I've merged your fix: https://github.com/ruby/fiddle/commit/760a8f9b1451a9391c349008660f29d43549e81b

----------------------------------------
Bug #11579: Fiddle.win32_last_error after calling Fiddle::Function#call isn't GetLastError()
https://bugs.ruby-lang.org/issues/11579#change-91615

* Author: cremno (cremno phobia)
* Status: Closed
* Priority: Normal
* Assignee: kou (Kouhei Sutou)
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN, 2.2: UNKNOWN
----------------------------------------
The current source code is:

~~~c
    rb_funcall(mFiddle, rb_intern("last_error="), 1, INT2NUM(errno));
#if defined(_WIN32)
    rb_funcall(mFiddle, rb_intern("win32_last_error="), 1, INT2NUM(errno));
#endif
~~~

I guess this is a copy-and-paste mistake and not the intended behavior. The attached patch is untested.

---Files--------------------------------
fix-fiddle-win32_last_error.diff (1.42 KB)


-- 
https://bugs.ruby-lang.org/

Unsubscribe: <mailto:ruby-core-request@ruby-lang.org?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>