[ruby-core:98607] [Ruby master Bug#14732] CGI.unescape returns different instance between Ruby 2.3 and 2.4

Issue #14732 has been updated by jeremyevans0 (Jeremy Evans).

Status changed from Open to Closed

I'm not sure if this behavior change between Ruby 2.3 and 2.4 was originally expected.  However, I don't see why we would want to revert to the previous, and the current behavior doesn't seem to be a bug.  Please submit a feature request if you would like to return to the Ruby <2.4 behavior.

----------------------------------------
Bug #14732: CGI.unescape returns different instance between Ruby 2.3 and 2.4
https://bugs.ruby-lang.org/issues/14732#change-85927

* Author: jnchito (Junichi Ito)
* Status: Closed
* Priority: Normal
* ruby -v: 2.4.4
* Backport: 2.3: REQUIRED, 2.4: REQUIRED, 2.5: REQUIRED
----------------------------------------
In Ruby 2.3, CGI.unescape always returns String object:

~~~ ruby
$ ruby -v -rcgi/util -e 'class S < String; end; puts CGI.unescape(S.new("a")).class'

ruby 2.3.6p384 (2017-12-14 revision 61254) [x86_64-darwin17]
String
~~~

But in Ruby 2.4, it might return non-String object when the argument value is not a String instance:

~~~ ruby
$ ruby -v -rcgi/util -e 'class S < String; end; puts CGI.unescape(S.new("a")).class'

ruby 2.4.4p296 (2018-03-28 revision 63013) [x86_64-darwin17]
S
~~~

This change triggered the following issue:

https://github.com/rest-client/rest-client/issues/662

Is this change intentional?



-- 
https://bugs.ruby-lang.org/

Unsubscribe: <mailto:[e-mail]?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>