Coverity: Patch/Fix CID 17 OVERRUN_STATIC File: ruby/signal.c

This is a simple out of bounds array access error.
The error checking code is off by 1.  > Should be >=.
Comments and suggestions welcome.
If there are no objections, could someone commit the fix.

Kevin Tew


CID: 17
Checker: OVERRUN_STATIC (help)
File: ruby/signal.c
Function: trap
Description: Overrun of static array "trap_list" of size 65 at
position 65 with index variable "sig"

static struct {
    VALUE cmd;
    int safe;
} trap_list[NSIG];

633         if (sig < 0 || sig > NSIG) {
634             rb_raise(rb_eArgError, "invalid signal number (%d)", sig);
635         }

trap_list is only NSIG big so the "if" should be >=NSIG
Arrays are zero based in C.


Index: signal.c
===================================================================
RCS file: /src/ruby/signal.c,v
retrieving revision 1.72
diff -u -r1.72 signal.c
--- signal.c    9 Jan 2006 22:32:55 -0000       1.72
+++ signal.c    5 May 2006 02:24:42 -0000
@@ -630,7 +630,7 @@
            rb_raise(rb_eArgError, "unsupported signal SIG%s", s);
     }
 
-    if (sig < 0 || sig > NSIG) {
+    if (sig < 0 || sig >= NSIG) {
        rb_raise(rb_eArgError, "invalid signal number (%d)", sig);
     }
 #if defined(HAVE_SETITIMER)