From: Pat Eyler <rubypate@...>
Date: 2006-05-03T11:11:32+09:00
Subject: one bug and one false positive defect in yaml2byte.c (we think)

We've been looking at coverity defects during our hacking night. there are two
potential bugs in yaml2byte.c.

The false positive is in syck_yaml2byte_handler.   Coverity can't find
an assignment or free for val.   It looks like it's being assigned to
in syck_add_sym (in st_insert).  We're pretty sure it's a false
positive, but if Why would like to check it ...


the bug (also identified by ville)  is in syck_yaml2byte_handler, and
involves type_tag not being freed.   This looks like the right fix. 
Why (or whomever), would you take a look at this and commit it if it's
good.


diff -p -u -r1.6 yaml2byte.c
--- yaml2byte.c 20 Sep 2005 06:50:20 -0000      1.6
+++ yaml2byte.c 3 May 2006 02:09:25 -0000
@@ -145,6 +145,7 @@ syck_yaml2byte_handler(p, n)
             strcat( type_tag, "!" );
             strcat( type_tag, n->type_id );
             bytestring_append( val, YAMLBYTE_TRANSFER, type_tag, NULL);
+           S_FREE(type_tag);
         }
     }
     switch (n->kind)