From: Joe Swatosh <joe.swatosh@...>
Date: 2016-04-15T12:04:25-07:00
Subject: [ruby-core:74974] Re: [Ruby trunk Bug#12264] Win32::Registry::API.DeleteKey and DeleteValue reference renamed constants

--===============1183518177==
Content-Type: multipart/alternative; boundary=94eb2c09361aec155d05308aad6d

--94eb2c09361aec155d05308aad6d
Content-Type: text/plain; charset=UTF-8

Thanks!

On Sun, Apr 10, 2016 at 4:50 AM, <nobu@ruby-lang.org> wrote:

> Issue #12264 has been updated by Nobuyoshi Nakada.
>
> Description updated
> Backport changed from 2.1: UNKNOWN, 2.2: UNKNOWN, 2.3: UNKNOWN to 2.1:
> REQUIRED, 2.2: REQUIRED, 2.3: REQUIRED
>
> ----------------------------------------
> Bug #12264: Win32::Registry::API.DeleteKey and DeleteValue reference
> renamed constants
> https://bugs.ruby-lang.org/issues/12264#change-57993
>
> * Author: Joe Swatosh
> * Status: Open
> * Priority: Normal
> * Assignee:
> * ruby -v: 2.1 and 2.2
> * Backport: 2.1: REQUIRED, 2.2: REQUIRED, 2.3: REQUIRED
> ----------------------------------------
> The fix for https://bugs.ruby-lang.org/issues/10820 (
> https://bugs.ruby-lang.org/projects/ruby-trunk/repository/revisions/49542)
> started using the wide version of the registry APIs.
>
> **************
> ```diff
> ---
> D:/Ruby/ruby-2.1.8-i386-mingw32/lib/ruby/2.1.0/win32/registry.rb.original
> Tue Jan 12 05:21:04 2016
> +++ D:/Ruby/ruby-2.1.8-i386-mingw32/lib/ruby/2.1.0/win32/registry.rb
> Mon Apr  4 08:17:45 2016
> @@ -321,11 +321,11 @@ For detail, see the MSDN[http://msdn.microsoft.com
>        end
>
>        def DeleteValue(hkey, name)
> -        check RegDeleteValue.call(hkey, make_wstr(name))
> +        check RegDeleteValueW.call(hkey, make_wstr(name))
>        end
>
>        def DeleteKey(hkey, name)
> -        check RegDeleteKey.call(hkey, make_wstr(name))
> +        check RegDeleteKeyW.call(hkey, make_wstr(name))
>        end
>
>        def FlushKey(hkey)
> ```
> *************************
>
> Is a follow up to make the referenced constants match the renames....
> Thanks!
>
> ---Files--------------------------------
> d.diff (656 Bytes)
>
>
> --
> https://bugs.ruby-lang.org/
>
> Unsubscribe: <mailto:ruby-core-request@ruby-lang.org?subject=unsubscribe>
> <http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>
>

--94eb2c09361aec155d05308aad6d
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Thanks!</div><div class=3D"gmail_extra"><br><div class=3D"=
gmail_quote">On Sun, Apr 10, 2016 at 4:50 AM,  <span dir=3D"ltr">&lt;<a hre=
f=3D"mailto:nobu@ruby-lang.org" target=3D"_blank">nobu@ruby-lang.org</a>&gt=
;</span> wrote:<br><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 =
.8ex;border-left:1px #ccc solid;padding-left:1ex">Issue #12264 has been upd=
ated by Nobuyoshi Nakada.<br>
<br>
Description updated<br>
Backport changed from 2.1: UNKNOWN, 2.2: UNKNOWN, 2.3: UNKNOWN to 2.1: REQU=
IRED, 2.2: REQUIRED, 2.3: REQUIRED<br>
<span class=3D""><br>
----------------------------------------<br>
Bug #12264: Win32::Registry::API.DeleteKey and DeleteValue reference rename=
d constants<br>
</span><a href=3D"https://bugs.ruby-lang.org/issues/12264#change-57993" rel=
=3D"noreferrer" target=3D"_blank">https://bugs.ruby-lang.org/issues/12264#c=
hange-57993</a><br>
<span class=3D""><br>
* Author: Joe Swatosh<br>
* Status: Open<br>
* Priority: Normal<br>
* Assignee:<br>
* ruby -v: 2.1 and 2.2<br>
</span>* Backport: 2.1: REQUIRED, 2.2: REQUIRED, 2.3: REQUIRED<br>
<span class=3D"">----------------------------------------<br>
The fix for <a href=3D"https://bugs.ruby-lang.org/issues/10820" rel=3D"nore=
ferrer" target=3D"_blank">https://bugs.ruby-lang.org/issues/10820</a> (<a h=
ref=3D"https://bugs.ruby-lang.org/projects/ruby-trunk/repository/revisions/=
49542" rel=3D"noreferrer" target=3D"_blank">https://bugs.ruby-lang.org/proj=
ects/ruby-trunk/repository/revisions/49542</a>) started using the wide vers=
ion of the registry APIs.<br>
<br>
**************<br>
</span>```diff<br>
<div class=3D"HOEnZb"><div class=3D"h5">--- D:/Ruby/ruby-2.1.8-i386-mingw32=
/lib/ruby/2.1.0/win32/registry.rb.original Tue Jan 12 05:21:04 2016<br>
+++ D:/Ruby/ruby-2.1.8-i386-mingw32/lib/ruby/2.1.0/win32/registry.rb=C2=A0 =
=C2=A0 Mon Apr=C2=A0 4 08:17:45 2016<br>
@@ -321,11 +321,11 @@ For detail, see the MSDN[<a href=3D"http://msdn.micro=
soft.com" rel=3D"noreferrer" target=3D"_blank">http://msdn.microsoft.com</a=
><br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0end<br>
<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0def DeleteValue(hkey, name)<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 check RegDeleteValue.call(hkey, make_wstr(name=
))<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 check RegDeleteValueW.call(hkey, make_wstr(nam=
e))<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0end<br>
<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0def DeleteKey(hkey, name)<br>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 check RegDeleteKey.call(hkey, make_wstr(name))=
<br>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 check RegDeleteKeyW.call(hkey, make_wstr(name)=
)<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0end<br>
<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0def FlushKey(hkey)<br>
```<br>
*************************<br>
<br>
Is a follow up to make the referenced constants match the renames.... Thank=
s!<br>
<br>
---Files--------------------------------<br>
d.diff (656 Bytes)<br>
<br>
<br>
--<br>
<a href=3D"https://bugs.ruby-lang.org/" rel=3D"noreferrer" target=3D"_blank=
">https://bugs.ruby-lang.org/</a><br>
<br>
Unsubscribe: &lt;mailto:<a href=3D"mailto:ruby-core-request@ruby-lang.org">=
ruby-core-request@ruby-lang.org</a>?subject=3Dunsubscribe&gt;<br>
&lt;<a href=3D"http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core=
" rel=3D"noreferrer" target=3D"_blank">http://lists.ruby-lang.org/cgi-bin/m=
ailman/options/ruby-core</a>&gt;<br>
</div></div></blockquote></div><br></div>

--94eb2c09361aec155d05308aad6d--

--===============1183518177==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline


Unsubscribe: <mailto:ruby-core-request@ruby-lang.org?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>

--===============1183518177==--