[#75225] [Ruby trunk Feature#12324] Support OpenSSL 1.1.0 (and drop support for 0.9.6/0.9.7) — k@...
Issue #12324 has been reported by Kazuki Yamaguchi.
6 messages
2016/04/27
[#78693] Re: [Ruby trunk Feature#12324] Support OpenSSL 1.1.0 (and drop support for 0.9.6/0.9.7)
— Eric Wong <normalperson@...>
2016/12/17
k@rhe.jp wrote:
[#78701] Re: [Ruby trunk Feature#12324] Support OpenSSL 1.1.0 (and drop support for 0.9.6/0.9.7)
— Kazuki Yamaguchi <k@...>
2016/12/17
On Sat, Dec 17, 2016 at 01:31:12AM +0000, Eric Wong wrote:
[#78702] Re: [Ruby trunk Feature#12324] Support OpenSSL 1.1.0 (and drop support for 0.9.6/0.9.7)
— Eric Wong <normalperson@...>
2016/12/17
Kazuki Yamaguchi <k@rhe.jp> wrote:
[ruby-core:74886] [Ruby trunk Bug#12182] openssl: NPN may be disabled by OpenSSL configuration
From:
naruse@...
Date:
2016-04-12 05:29:17 UTC
List:
ruby-core #74886
Issue #12182 has been updated by Yui NARUSE. Backport changed from 2.1: DONE, 2.2: DONE, 2.3: REQUIRED to 2.1: DONE, 2.2: DONE, 2.3: DONE ruby_2_3 r54551 merged revision(s) 54258. ---------------------------------------- Bug #12182: openssl: NPN may be disabled by OpenSSL configuration https://bugs.ruby-lang.org/issues/12182#change-58013 * Author: Kazuki Yamaguchi * Status: Closed * Priority: Normal * Assignee: * ruby -v: * Backport: 2.1: DONE, 2.2: DONE, 2.3: DONE ---------------------------------------- OpenSSL's NPN support can be disabled, and Ruby doesn't work well when it is disabled. ~~~ % make test-all TESTS="test/openssl" ... # Running tests: [274/358] OpenSSL::TestSSL#test_npn_advertised_protocol_too_long./test/runner.rb: OpenSSL::TestSSL#test_npn_advertised_protocol_too_long: symbol lookup error: /work/ruby-src/.ext/x86_64-linux/openssl.so: undefined symbol: SSL_CTX_set_next_proto_select_cb uncommon.mk:607: recipe for target 'yes-test-all' failed make: *** [yes-test-all] Error 127 ~~~ We should detect that the OpenSSL has NPN support by checking existence of `SSL_CTX_set_next_proto_select_cb`, not of `OPENSSL_NPN_NEGOTIATED`. This is because `OPENSSL_NPN_NEGOTIATED` macro always exists even if NPN is disabled. I attached a patch which fixes this. ---Files-------------------------------- 0001-openssl-fix-build-when-NPN-is-disabled-by-OpenSSL.patch (5.43 KB) -- https://bugs.ruby-lang.org/ Unsubscribe: <mailto:ruby-core-request@ruby-lang.org?subject=unsubscribe> <http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>