[ruby-core:74802] [Ruby trunk Bug#12202] nkf.c static void mime_putc the variable being used for loop used for outer loop too

Issue #12202 has been updated by Anton Sivakov.


Yui NARUSE wrote:
> Applied in changeset r54423.
> 
> ----------
> * ext/nkf/nkf-utf8/nkf.c: Merge upstream 4f3edf80a0.
>   patched by Anton Sivakov [Bug #12201] [Bug #12202]

Hi. I saw your changes and now it's: 
...
for (j=0;i<mimeout_state.count;j++) {
  (*o_mputc)(mimeout_state.buf[j]);
...

Now you're using 'j' but on condition you still using 'i'. Is it ok or mistake?

----------------------------------------
Bug #12202: nkf.c  static void mime_putc the variable being used for loop used for outer loop too
https://bugs.ruby-lang.org/issues/12202#change-57927

* Author: Anton Sivakov
* Status: Closed
* Priority: Normal
* Assignee: 
* ruby -v: 
* Backport: 2.1: UNKNOWN, 2.2: UNKNOWN, 2.3: UNKNOWN
----------------------------------------
~~~
for (i=0;i<mimeout_state.count;i++) {
  if (SP<mimeout_state.buf[i] && mimeout_state.buf[i]<DEL) {
    eof_mime();
    for (i=0;i<mimeout_state.count;i++) {
      (*o_mputc)(mimeout_state.buf[i]);
      base64_count++;
    }
    mimeout_state.count = 0;
  }
}
~~~

Variable 'i' here used for outer and inner loop.
Also variable mimeout_state.count can be changed within a loop it can affect outer loop



-- 
https://bugs.ruby-lang.org/

Unsubscribe: <mailto:[e-mail]?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>