[ruby-core:24754] [Bug #1883] REXML hash sometimes computes a value that is too large

Bug #1883: REXML hash sometimes computes a value that is too large
http://redmine.ruby-lang.org/issues/show/1883

Author: Ryan Riley
Status: Open, Priority: Normal
ruby -v: 1.8.6p287

The hash method sometimes computes a value that is too large. This is a rare occurrence in MRI, but this is causing problems for IronRuby. The following patch is suggested for computing smaller hashes:

edit: c:/ruby/libs/ruby/1.8/rexml/attribute.rb;C908357
File: attribute.rb
===================================================================
--- c:/ruby/libs/ruby/1.8/rexml/attribute.rb;C908357  (server)    6/23/2009 1:24 PM
+++ c:/ruby/libs/ruby/1.8/rexml/attribute.rb
@@ -93,7 +93,7 @@
 
 		# Creates (and returns) a hash from both the name and value
 		def hash
-			name.hash + value.hash
+			name.hash ^ value.hash
 		end
 
 		# Returns this attribute out as XML source, expanding the name
===================================================================


----------------------------------------
http://redmine.ruby-lang.org