From: merch-redmine@... Date: 2020-02-24T21:26:26+00:00 Subject: [ruby-core:97252] [Ruby master Bug#16642] Splatted empty hash literal produces frozen hash object Issue #16642 has been updated by jeremyevans0 (Jeremy Evans). Backport changed from 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN to 2.5: DONTNEED, 2.6: DONTNEED, 2.7: REQUIRED ruby -v set to ruby 2.7.1p37 (2020-02-20) [x86_64-openbsd6.6] Status changed from Open to Closed File ruby2_keywords-empty-kw-splat-16642.patch added This was already fixed in master at commit:f8a8f055123bc81fc13fa295b936504196df0da4, which changed it so ruby2_keywords does not pass empty keyword splats as hashes. Passing empty keyword splats as hashes is not needed in Ruby 3, it is only needed in Ruby 2.7 to avoid a final positional hash from being treated as keywords in a later method call. Attached is a patch that fixes this in Ruby 2.7. ---------------------------------------- Bug #16642: Splatted empty hash literal produces frozen hash object https://bugs.ruby-lang.org/issues/16642#change-84368 * Author: Dan0042 (Daniel DeLorme) * Status: Closed * Priority: Normal * ruby -v: ruby 2.7.1p37 (2020-02-20) [x86_64-openbsd6.6] * Backport: 2.5: DONTNEED, 2.6: DONTNEED, 2.7: REQUIRED ---------------------------------------- When splatting an empty hash literal, internally it's optimized using a global frozen hash object, but this implementation detail can leak into the ruby code outside: ```ruby ruby2_keywords def foo(*a) a.last end h = foo(**{}) h[1] = 2 # can't modify frozen Hash: {} (FrozenError) ``` I think this can be considered a bug? ---Files-------------------------------- ruby2_keywords-empty-kw-splat-16642.patch (2.49 KB) -- https://bugs.ruby-lang.org/ Unsubscribe: