From: alex.wayfer@... Date: 2020-02-06T13:25:53+00:00 Subject: [ruby-core:97072] [Ruby master Bug#14909] Method call with object that has to_hash method crashes (method with splat and keyword arguments) Issue #14909 has been updated by AlexWayfer (Alexander Popov). There are problems with Sequel Models, which have `#to_hash` method (implicit conversion), and Memery gem, which defines methods with `*args, **kwargs, &block` (`**kwargs` was added after warning from Ruby 2.7). So, Sequel Models as arguments for memoized methods becomes Hashes and it breaks everything. The `**(;{})` approach is: * unclear for me (what it does in Ruby?); * additional changes at every call; * offenses RuboCop (should be resolved there, yes). I'll try to make dynamic methods definition in Memery with exactly expected parameters instead of `*args, **kwargs, &block`, but it's harder. ---------------------------------------- Bug #14909: Method call with object that has to_hash method crashes (method with splat and keyword arguments) https://bugs.ruby-lang.org/issues/14909#change-84178 * Author: johannes_luedke (Johannes L�dke) * Status: Closed * Priority: Normal * ruby -v: ruby 2.4.1p111 (2017-03-22 revision 58053) [x86_64-darwin17] * Backport: 2.3: UNKNOWN, 2.4: UNKNOWN, 2.5: UNKNOWN ---------------------------------------- In a method with a splat method argument followed by a keyword argument, it leads to an `ArgumentError` when calling the method with an object that reacts to `to_hash` ~~~ruby def my_func(*objects, error_code: 400) objects.inspect end class Test def to_hash # an example hash { to_hash_key: "to_hash" } end end my_func(Test.new) ~~~ Observed result: an exception is raised: `in my_func: unknown keyword: to_hash_key (ArgumentError)` Expected result: `[#]` is returned by the `my_func` call It should behave the same when calling with objects that have a `to_hash` method and objects that don't, shouldn't it? -- https://bugs.ruby-lang.org/ Unsubscribe: