[ ruby-Bugs-1823 ] NUM2UINT does not rase RangError for negative Fixnum

Bugs item #1823, was opened at 2005-04-22 11:34
You can respond by visiting: 
http://rubyforge.org/tracker/?func=detail&atid=1698&aid=1823&group_id=426

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Michael Schonberg (mschonberg)
Assigned to: Nobody (None)
Summary: NUM2UINT does not rase RangError for negative Fixnum

Initial Comment:
NUM2UINT does not rase RangError for negative Fixnum. If a Fixnum is < 0, NUM2UINT(value) should raise a RangeError since an unsigned int can not be negative. 

Adding the following to my code fixed the problem:
    if( FIXNUM_P(val) && ( val & 0x04000000 ) )
    {
        rb_raise( rb_eRangeError, "unsigned int can not be less than 0" );
    }

I believe that changing rb_num2ulong to:

    unsigned long
    rb_num2ulong(val)
        VALUE val;
    {
        if (TYPE(val) == T_BIGNUM) {
	    return rb_big2ulong(val);
        }
        else if (FIXNUM_P(val) && (val & 0x04000000)) {
            rb_raise(rb_eRangeError, "unsigned int can not be < 0")
        }
        return (unsigned long)rb_num2long(val);
    }
in numeric.c will fix the problem. I am not certain if the same problem exists when SIZEOF_INT < SIZEOF_LONG.

----------------------------------------------------------------------

You can respond by visiting: 
http://rubyforge.org/tracker/?func=detail&atid=1698&aid=1823&group_id=426