Re: [PATCH] Trivial speedup in Array#zip

Hi,

At Tue, 19 Apr 2005 08:38:08 +0900,
Mauricio Fern疣dez wrote in [ruby-core:04736]:
> --- array.c.orig        2005-04-18 00:11:33.000000000 +0200
> +++ array.c     2005-04-18 00:22:18.000000000 +0200
> @@ -2074,12 +2074,12 @@
>         argv[i] = to_ary(argv[i]);
>      }
>      if (rb_block_given_p()) {
> +        VALUE tmp = rb_ary_new2(argc+1);
> +        RARRAY(tmp)->len = argc + 1;
>         for (i=0; i<RARRAY(ary)->len; i++) {
> -           VALUE tmp = rb_ary_new2(argc+1);
> -
> -           rb_ary_push(tmp, rb_ary_elt(ary, i));
> +            RARRAY(tmp)->ptr[0] = RARRAY(ary)->ptr[i];
>             for (j=0; j<argc; j++) {
> -               rb_ary_push(tmp, rb_ary_elt(argv[j], i));
> +                RARRAY(tmp)->ptr[1+j] = rb_ary_elt(argv[j], i);
>             }
>             rb_yield(tmp);
>         }

`tmp' can be modified or stored anywhere while yielding, so it
should not be reused.  You can't assume that the size is
constant, at least.

# and the indent doesn't seem consistent.

-- 
Nobu Nakada