Re: Segfault in zlib?

>Yes it does... thank you for your help.

OK, this is ext/zlib's GC related bug.

zstream_run:

    z->stream.next_in = RSTRING(z->input)->ptr; /* extract bare pointer */

    .....

    zstream_reset_input(z); /* actually does z->input = Qnil. reachable reference is gone. */
    if (z->stream.avail_in > 0) {
	zstream_append_input(z, z->stream.next_in, z->stream.avail_in);
    }


static void
zstream_append_input(z, src, len)
    struct zstream *z;
    const char *src;
    unsigned int len;
{
    if (len <= 0) return;

    if (NIL_P(z->input)) {
	z->input = rb_str_buf_new(len); /* if GC happen, string object is freed, and
                                           src (== z->stream.next_in) becomes dangling pointer */
	rb_str_buf_cat(z->input, src, len); /* SEGV */
	RBASIC(z->input)->klass = 0;
    }
    else {
	rb_str_buf_cat(z->input, src, len); /* same here */
    }
}


>It would be good if this was merged before 1.8.3.

I've commited. Thank you.