ruby-list

大島です。

From: ryu@jaist.ac.jp
Subject: [ruby-list:26451] Re: cgi.rb で 	InsecureOperation
Date: Fri, 8 Dec 2000 17:26:04 +0900

> rbnamazu-0.4 は ruby-1.4.6 でも動くんじゃないかと思っていましたが、
> 正規表現の m オプションで引っ掛かりますね。考えてみると m オプション
> は無くても問題なさそうなので除去します。ついでに、eval()を使っていた
> 部分はセキュリティ的にまずいので、eval()を使わないように変更しました。
> 以下に rbnamazu-0.4 へのパッチを添付します。

このメールのパッチでは不十分でした。ぼけていて、正規表現の m オプショ
ンを n オプションを混同してしまっていました。代りに以下のパッチを使っ
てください。

いずれにせよ、rbnamazuの出力関連はまだ処理がかなり甘いので、近いうち
に修正します。

大島 龍之介	ryu@jaist.ac.jp

Attachments (1)

rbnamazu-0.4.diff (3.69 KB, text/x-diff)

diff -ur rbnamazu-0.4/nmzdoc.rb current/nmzdoc.rb
--- rbnamazu-0.4/nmzdoc.rb	Mon Dec  4 01:50:14 2000
+++ current/nmzdoc.rb	Sat Dec  9 19:48:48 2000
@@ -241,22 +241,33 @@
       open(@templatedirname + templatename) do |file|
 	template = file.read()
       end
-      template.gsub!(/<form.*<\/form>/im, '') unless @options['form']
+      template.gsub!(/<form[\S\s]*?<\/form[^>]*?>/i, '') unless @options['form']
       template.gsub!(/\{cgi\}/i, File.basename($0))
-      template.gsub!(/\$\{(namazu::)?([^\}]+)\}/, '#{\2}')
+      template.gsub!(/\$\{(namazu::)?([^\}]+?)\}/i, '#{\2}')
       if querystring
-	querystring = querystring.gsub(/&/n, '&amp;').gsub(/\"/n, '&quot;').gsub(/>/n, '&gt;').gsub(/</n, '&lt;')
-	template.gsub!(/(<input[^>]+name="query"[^>]*)>/im,
+	querystring = querystring.gsub(/[&\"><]/n) do
+	  case $&
+	  when '&'
+	    '&amp;'
+	  when '"'
+	    '&quot;'
+	  when '>'
+	    '&gt;'
+	  when '<'
+	    '&lt;'
+	  end
+	end
+	template.gsub!(/(<input[^>]+?name="?query"?[^>]*?)>/i,
 			  '\1 value="'+ querystring + '">')
-	template.gsub!(/<\/title>/i, ': &lt;' + querystring + '&gt;\&')
+	template.gsub!(/<\/title[^>]*?>/i, ': &lt;' + querystring + '&gt;\&')
       end
       @options.each() do |key, value|
-	template.gsub!(/<select[^>]+name="#{key}".*?<\/select>/im) do
+	template.gsub!(/<select[^>]+?name="?#{key}"?[\S\s]*?<\/select[^>]*?>/i) do
 	  |selections|
-	  selections.gsub!(/\s*selected\s*/im, ' ')
-	  unless selections.gsub!(/(<option[^>]+value="#{value}"[^>]*)>/im,
+	  selections.gsub!(/\s*selected\s*/i, ' ')
+	  unless selections.gsub!(/(<option[^>]+?value="?#{value}"?[^>]*?)>/i,
 				  '\1 selected>')
-	    selections.sub!(/<\/select>/im,
+	    selections.sub!(/<\/select[^>]*?>/i,
 			    '<option value="' + value.to_s() +
 			    '" selected>' + value.to_s() + "\n" + '\&')
 	  end
@@ -304,11 +315,13 @@
 	end
       end
 
-      tmpresult = nil
+      public_values = {}
       (result << "<dl>\n") if @options['html']
       counter = nmzsummary.whence() + 1
-      uri = title = score = i = author = date = summary = size = nil
+      i = uri = score = size = nil
       for listno in (1 .. nmzsummary.maxlength())
+	public_values['counter'] = counter
+	public_values['listno'] = listno
 	uri = nmzsummary[counter - 1]['uri']
 	if @options['decode-uri']
 	  uri.tr!('+', ' ')
@@ -321,24 +334,27 @@
 	    uri.sub!(*value)
 	  end
 	end
-	title = nmzsummary[counter - 1]['subject']
+	public_values['uri'] = uri
+	public_values['title'] = nmzsummary[counter - 1]['subject']
 	score = nmzsummary[counter - 1]['score'].to_i().to_s()
 	i = (score.length() - 1) % 3 + 1
 	while (i < score.length())
 	  score[i, 0] = ','
 	  i += 4
 	end
-	author = nmzsummary[counter - 1]['from']
-	date = nmzsummary[counter - 1]['date']
-	summary = nmzsummary[counter - 1]['summary']
+	public_values['score'] = score
+	public_values['author'] = nmzsummary[counter - 1]['from']
+	public_values['date'] = nmzsummary[counter - 1]['date']
+	public_values['summary'] = nmzsummary[counter - 1]['summary']
 	size = nmzsummary[counter - 1]['size']
 	i = (size.length() - 1) % 3 + 1
 	while (i < size.length())
 	  size[i, 0] = ','
 	  i += 4
 	end
-	eval("tmpresult = %Q\x1f" + resulttemplate + "\n\x1f")
-	result << tmpresult
+	public_values['size'] = size
+	result << resulttemplate.gsub(/\#{(.*?)}/) do public_values[$1]	end
+	result << "\n"
 	counter += 1
       end
       (result << "</dl>\n") if @options['html']
@@ -414,9 +430,9 @@
     private
     def html2text(html)
       text = html.dup()
-      text.gsub!(/<!--.*?-->/im, '')
-      text.gsub!(/<.*?>/im, '')
-      text.gsub!(/\n{3,}/im, "\n\n")
+      text.gsub!(/<!--[\S\s]*?-->/i, '')
+      text.gsub!(/<[^>]*?>/i, '')
+      text.gsub!(/\n{3,}/i, "\n\n")
       text
     end

Thread

Prev Next

In This Thread

Prev Next

[#26241] postgres を CGI の中から require できません — ITO Yoshiaki <yoshi@...>

[#26249] prc2k の dRuby のスライド — Masatoshi SEKI <m_seki@...>

[#26250] bind in UDPSocket — "Shigeo Kobayashi" <shigeo@...>

[#26253] Perl/Ruby Conference — matz@... (Yukihiro Matsumoto)

[#26261] Multiple ways to say it — SHUDO Kazuyuki <shudoh@...>

[#26268] Re: [ruby-talk:6666] Suggestion for addition to Begin/End syntax — ARIMA Yasuhiro <fit0298@...>

[#26274] アプリにマクロをつけるのについて — polygon <kiyose@...>

[#26278] Ruby/KAKASI bug? — SHIRAKURA Tetsuya <shirakura@...>

[#26292] require の影響を特定の場所だけにしたい — Kazuhiro NISHIYAMA <zn@...>

[#26293] ENV.inspect — Kazuhiro NISHIYAMA <zn@...>

[#26294] 特定の interface だけで listen — Kazuhiro NISHIYAMA <zn@...>

[#26295] tail -f のように読み続ける方法は？ — Kazuhiro NISHIYAMA <zn@...>

[#26309] DDJ — KIMURA Koichi <kimura.koichi@...>

[#26312] prc2k の「入門 Ruby 」の資料 — Shin-ichiro Hara <sinara@...>

[#26313] 並行するスレッドの記述法について — Kenya OGATA <ind.onosetu1@...>

[#26314] ruby-mode on Emacs 21 — ABE Yasushi (阿部 靖司) <yasushi@...>

[#26341] COM sort? — Shin-ichiro Hara <sinara@...>

[#26344] Re: COM sort? — "Okada Jun" <yun@...>

[#26345] Re: COM sort? — "Okada Jun" <yun@...>

[#26359] nplant — masahiro kawata <mas@...>

[#26381] はじめまして — tkondo@...

[#26384] [PATCH] stupid bug/miss — "Nobuyoshi.Nakada" <nobu.nakada@...>

[#26405] windowsでcursesを使うには — kawasaki <user0013@...>

[#26408] オープンソースまつり — akira yamada / やまだあきら <akira@...>

[#26410] NHK 取材 — matz@... (Yukihiro Matsumoto)

[#26413] TMail: UNIX From in MH format(?) — OZAWA -Crouton- Sakuro <crouton@...>

[#26415] cgi.rb で InsecureOperation — Takeshi Komiya <katsuwo@...>

[#26424] Re: windows で curses を使うには — kawasaki <user0013@...>

[#26432] File.open のブロック中で exec — OZAWA -Crouton- Sakuro <crouton@...>

[#26433] [RD]rd2html HeadLine patch — rubikitch <rubikitch@...>

[#26435] Ruby デスクトップリファレンス正誤表 — matz@... (Yukihiro Matsumoto)

[#26436] Array#& — WATANABE Tetsuya <tetsu@...>

[#26461] Gtk::Widget.allocation の呼び方 — Hirotaka Matsuyuki <h-maty@...6.dion.ne.jp>

[#26475] Regexp.new のオプション — URA Takefumi <hage@...>

[#26497] Time.strftime の %Z について — Kenya OGATA <ind.onosetu1@...>

[#26506] Re: Time.strftime の %Z について — Kenya OGATA <ind.onosetu1@...>

[#26509] mod_ruby 公式サイト (FAQ とか) — Shugo Maeda <shugo@...>

[#26513] media watch 2000.12.08 — Noritsugu Nakamura <nnakamur@...>

[#26516] n-fold loop — Hiroshi SATO <hiroshi@...>

[#26529] Re: n-fold loop — Shin-ichiro HARA <sinara@...>

[#26530] MySQL 本 (media watch?) — とみたまさひろ <tommy@...>

[#26531] Re: n-fold loop — Shin-ichiro HARA <sinara@...>

[#26532] Win で dRuby — m_seki@...

[#26536] ファイル名が文字化け — KUROSAWA Takashi <tabby@...>

[#26547] size of raa — Minero Aoki <aamine@...>

[#26554] Hash.new — Takao KAWAMURA <kawamura@...>

[#26557] IPC module for ruby — Kengo Nakajima <ringo@...>

[#26574] glossary.en.rd — maili31s@... (SugHimsi as SUGIHARA Hiroshi)

[#26575] XPath — Ueno Katsuhiro <unnie@...>

[#26581] drb-1.3 — Masatoshi SEKI <m_seki@...>

[#26595] tcltklib on FreeBSD 4.1R — gotoken@... (GOTO Kentaro)

[#26605] [Q] Oracle PL/SQL with bind vars — Hideto ISHIBASHI <hideto-i@...4u.or.jp>

[#26609] net/http,smtp,pop 1.2 pre 1 — Minero Aoki <aamine@...>

[#26610] some issues on cgi.rb — YANAGAWA Kazuhisa <kjana@...>

[#26611] sink-1.0a1 — Masatoshi SEKI <m_seki@...>

[#26625] multiple args for Singleton#instance — Yasushi Shoji <yashi@...>

[#26628] Hash.reject returns a Hash? — Takao KAWAMURA <kawamura@...>

[#26635] (watch?) flex.rb — Sato Daisuke <densuke@...2.so-net.ne.jp>

[#26658] cgi.rb and Regexp::last_match — OHSHIMA Ryunosuke <ryu@...>

[#26659] FILE.eof などについて — Hiroyuki Kai <hiroyuki@...104.net>

[#26667] racc -E — Tadayoshi Funaba <tadf@...>

[#26670] Re: cgi.rb and Regexp::last_match — "K.Kosako" <kosako@...>

[#26673] Ruby Newbie — "Harry Mathews" <mathews@...>

[#26674] uri.rb 4.22 patch — OHSHIMA Ryunosuke <ryu@...>

[#26693] media watch 2000.12.18 — Noritsugu Nakamura <nnakamur@...>

[#26700] cygwin 版の eruby が動きません。 — Keisuke Minami <keisuke@...>

[#26719] Re: Ruby Newbie — "Harry Mathews" <mathews@...>

[#26725] ruby 1.6.2-preview4 — matz@... (Yukihiro Matsumoto)

[#26735] gpib-rb — kiwamu <kiwamu@...>

[#26744] Re: ruby 1.6.2-preview4 — "Okada Jun" <yun@...>

[#26745] misc — "ページコム佐藤" <k-satoh@...>

[#26750] Ruby SHINNENKAI 2001 — TAKAHASHI Masayoshi <maki@...>

[#26789] patch: singleton.rb — MOROHOSHI Akihiko <moro@...>

[#26793] p File.join('/','test') — " たけ (tk)" <ggb03124@...>

[#26799] evel & rescue — " たけ (tk)" <ggb03124@...>

[#26803] ruby-mode.el: / — Takao KAWAMURA <kawamura@...>

[#26846] Ruby 1.6.2 — matz@... (Yukihiro Matsumoto)

[#26865] Windows2000 について — 石田 宏香 <h-ishida@...>

[#26875] cgi.rb <form>element BUG — MoonWolf <moonwolf@...>

[#26886] erb-1.3.2 — Masatoshi SEKI <m_seki@...>

[#26314] ruby-mode on Emacs 21 — ABE Yasushi (阿部靖司) <yasushi@...>

[#26865] Windows2000 について — 石田宏香 <h-ishida@...>