[ruby-dev:23241] Re: [ruby-cvs] ruby, ruby/lib, ruby/lib/rss, ruby/sample/openssl: * lib/logger.rb: trim tail space of each line. no user visible change.

須藤です．

In <002101c413ce$e2b46380$04e6a8c0@CFR2>
  "[ruby-dev:23239] Re: [ruby-cvs] ruby, ruby/lib, ruby/lib/rss, ruby/sample/openssl: * lib/logger.rb: trim tail space of each line. no user visible change." on Sat, 27 Mar 2004 16:37:50 +0900,
  "NAKAMURA, Hiroshi" <[e-mail]> wrote:

> なひ個人の好みだけ言えば、定義順で挙動が変わる（そのファイルだけ見ても
> わからない）のは、好きじゃないです。

定義は一ヶ所で行われていた方がいいということですよね？

例えば今回の場合は，以下のように，メソッド呼び出しで代替する
と，定義が分散されていない気がするようになりますか？

もしそうであれば，こういう書き方にしようと思います．

Index: lib/rss/dublincore.rb
===================================================================
RCS file: /src/ruby/lib/rss/dublincore.rb,v
retrieving revision 1.6
diff -u -p -r1.6 dublincore.rb
--- lib/rss/dublincore.rb	26 Mar 2004 16:47:16 -0000	1.6
+++ lib/rss/dublincore.rb	27 Mar 2004 12:35:48 -0000
@@ -46,11 +46,13 @@ module RSS
 	# For backward compatibility
 	DublincoreModel = DublinCoreModel
 
-	class RDF < Element
-		class Channel < Element; include DublinCoreModel; end
-		class Image < Element; include DublinCoreModel; end
-		class Item < Element; include DublinCoreModel; end
-		class Textinput < Element; include DublinCoreModel; end
+	[
+		RDF::Channel,
+		RDF::Image,
+		RDF::Item,
+		RDF::Textinput,
+	].each do |target|
+		target.install_model_module(DublinCoreModel)
 	end
 
 	prefix_size = DC_PREFIX.size + 1
Index: lib/rss/rss.rb
===================================================================
RCS file: /src/ruby/lib/rss/rss.rb,v
retrieving revision 1.6
diff -u -p -r1.6 rss.rb
--- lib/rss/rss.rb	21 Mar 2004 09:54:07 -0000	1.6
+++ lib/rss/rss.rb	27 Mar 2004 12:35:49 -0000
@@ -395,6 +395,10 @@ EOC
 				self::NSPOOL[prefix] = uri
 			end
 
+			def install_model_module(mod)
+				include mod
+			end
+
 		end
 
 		attr_accessor :do_validate