From: SASADA Koichi <ko1@...>
Date: 2017-05-27T15:48:03+09:00
Subject: [ruby-core:81413] Fwd: [ruby-changes:46804] normal:r58919 (trunk): common: "test-all" depends on "exts" target

Hi Eric,

CI expect that yes-test-all doesn't depend on "exts" because they do
something like:

```
  make all # prepare all of binaries
  ...
  make yes-test-all
```

Problem is that logs become longer like
https://gist.github.com/ko1/4156117000d1863f5cf9c0a249e99646

I'm not sure test-all should depend on exts (some days ago nobu removed
dependency) but don't add dependency to "yes-test-all".

Thanks,
Koichi

-------- Forwarded Message --------
Subject: [ruby-changes:46804] normal:r58919 (trunk): common: "test-all"
depends on "exts" target
Date: Sat, 27 May 2017 13:35:46 +0900 (JST)
From: normal <ko1@atdot.net>
Reply-To: ruby-changes@quickml.atdot.net
To: ruby-changes@quickml.atdot.net

normal	2017-05-27 13:35:41 +0900 (Sat, 27 May 2017)

  New Revision: 58919

  https://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=58919

  Log:
    common: "test-all" depends on "exts" target
        This allows me to test changes to ext/ more easily by only typing:
          make test-all TESTS=/path/to/ext/test_foo.rb
        I spent a few minutes wondering what was wrong before I realized
    changes to exts were not taking effect.

  Modified files:
    trunk/common.mk
Index: common.mk
===================================================================
--- common.mk	(revision 58918)
+++ common.mk	(revision 58919)
@@ -676,7 +676,7 @@ test: btest-ruby test-knownbug test-basi
https://github.com/ruby/ruby/blob/trunk/common.mk#L676
 # $ make test-all TESTOPTS="--help" displays more detail
 # for example, make test-all TESTOPTS="-j2 -v -n test-name --
test-file-name"
 test-all: $(TEST_RUNNABLE)-test-all
-yes-test-all: programs PHONY
+yes-test-all: programs exts PHONY
 	$(gnumake_recursive)$(Q)$(exec) $(RUNRUBY) "$(srcdir)/test/runner.rb"
--ruby="$(RUNRUBY)" $(TEST_EXCLUDES) $(TESTOPTS) $(TESTS)
 TESTS_BUILD = mkmf
 no-test-all: PHONY

--
ML: ruby-changes@quickml.atdot.net
Info: http://www.atdot.net/~ko1/quickml/

Unsubscribe: <mailto:ruby-core-request@ruby-lang.org?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>