From: hanmac@... Date: 2017-05-15T12:01:05+00:00 Subject: [ruby-core:81181] [Ruby trunk Feature#13568] File#path for O_TMPFILE fds are unmeaning Issue #13568 has been updated by Hanmac (Hans Mackowiak). i see your change and did read the man page of O_TMPFILE to check if there is any useful path this could return. (there isn't) now i am pro this change. does ruby has a way to use linkat like to seen there? http://man7.org/linux/man-pages/man2/open.2.html hm about Tempfile, does it already use O_TMPFILE internal, or can it maybe changed to that? (might probably for another ticket if not already done) as for my code change, i thought it would be better if you don't have a duplicated line in there ---------------------------------------- Feature #13568: File#path for O_TMPFILE fds are unmeaning https://bugs.ruby-lang.org/issues/13568#change-64821 * Author: sorah (Sorah Fukumori) * Status: Open * Priority: Normal * Assignee: * Target version: ---------------------------------------- By using File::TMPFILE (O_TMPFILE) allows us to create a file without directory entries. While open(2) with O_TMPFILE don't create a file without directory entries, it still requires a directory name to determine a file system to create a file. Current Ruby implementation holds such directory names in fptr->pathv and retrievable via File#path. But such paths are useless and may raise errors. For example, some code [1] checks File#path availability then when available, it attempts to use the path to open a file in different fd, finally raises Errno::EISDIR. This patch changes File#path (fptr->pathv) not to return String if a fd is opened with O_TMPFILE. [1]: https://github.com/aws/aws-sdk-ruby/blob/v2.9.17/aws-sdk-core/lib/aws-sdk-core/checksums.rb#L15 ---Files-------------------------------- tmpfile-path.patch (1.96 KB) -- https://bugs.ruby-lang.org/ Unsubscribe: