[ruby-core:81224] [Ruby trunk Bug#13040] syslog/logger uses "require 'logger'" which is interpreted as circular dependency

Issue #13040 has been updated by lemsx1 (Luis Mondesi).


Am I the only person having this problem? This is in different code sources we are maintaining. Here is the latest. In a new project I setup test with minitest/spec

1. added pp $LOAD_PATH to my test_helper.rb
2. rake test

$> rake test
["/Users/lmondesi/Projects/new_project/lib",
 "/Users/lmondesi/Projects/new_project/lib/new_project",
 "/usr/local/lib/ruby/gems/2.4.0/gems/rake-12.0.0/lib",
 "/usr/local/lib/ruby/gems/2.4.0/gems/did_you_mean-1.1.0/lib",
 "/usr/local/lib/ruby/gems/2.4.0/gems/minitest-5.10.1/lib",
 "/usr/local/lib/ruby/site_ruby/2.4.0",
 "/usr/local/lib/ruby/site_ruby/2.4.0/x86_64-darwin16",
 "/usr/local/lib/ruby/site_ruby",
 "/usr/local/lib/ruby/vendor_ruby/2.4.0",
 "/usr/local/lib/ruby/vendor_ruby/2.4.0/x86_64-darwin16",
 "/usr/local/lib/ruby/vendor_ruby",
 "/usr/local/Cellar/ruby/2.4.1_1/lib/ruby/2.4.0",
 "/usr/local/Cellar/ruby/2.4.1_1/lib/ruby/2.4.0/x86_64-darwin16"]
/usr/local/Cellar/ruby/2.4.1_1/lib/ruby/2.4.0/syslog/logger.rb:81:in `<class:Logger>': uninitialized constant Logger (NameError)
	from /usr/local/Cellar/ruby/2.4.1_1/lib/ruby/2.4.0/syslog/logger.rb:48:in `<top (required)>'
	from /usr/local/Cellar/ruby/2.4.1_1/lib/ruby/2.4.0/rubygems/core_ext/kernel_require.rb:55:in `require'
	from /usr/local/Cellar/ruby/2.4.1_1/lib/ruby/2.4.0/rubygems/core_ext/kernel_require.rb:55:in `require'

----------------------------------------
Bug #13040: syslog/logger uses "require 'logger'" which is interpreted as circular dependency 
https://bugs.ruby-lang.org/issues/13040#change-64878

* Author: lemsx1 (Luis Mondesi)
* Status: Feedback
* Priority: Normal
* Assignee: 
* Target version: 
* ruby -v: ruby 2.3.1p112 (2016-04-26 revision 54768) [x86_64-linux]
* Backport: 2.1: UNKNOWN, 2.2: UNKNOWN, 2.3: UNKNOWN
----------------------------------------
while using the 'syslog/logger' require from Ruby it works well, however if one tries to use it via "test" it complaints about circular require and the constant "Logger" not defined. After a little digging, I realized that 'syslog/logger' has a line that says require 'logger' which could mean itself!

The fix is to use require_relative '../logger' as this is what it intends in order to piggy back on Logger:

Current code for syslog/logger:

1. # frozen_string_literal: false
2. require 'syslog'
3. require 'logger'

Fixed code:

1. # frozen_string_literal: false
2. require 'syslog'
3. require_relative '../logger'



-- 
https://bugs.ruby-lang.org/

Unsubscribe: <mailto:[e-mail]?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>