From: nagachika00@... Date: 2017-05-09T15:24:18+00:00 Subject: [ruby-core:81072] [Ruby trunk Bug#13387] [PATCH]Add parenthesis to fix compile warning to string.c Issue #13387 has been updated by nagachika (Tomoyuki Chikanaga). Backport changed from 2.2: DONTNEED, 2.3: DONTNEED, 2.4: REQUIRED to 2.2: DONTNEED, 2.3: DONTNEED, 2.4: DONE ruby_2_4 r58635 merged revision(s) 58211. ---------------------------------------- Bug #13387: [PATCH]Add parenthesis to fix compile warning to string.c https://bugs.ruby-lang.org/issues/13387#change-64723 * Author: litmon (Fukuo Kadota) * Status: Closed * Priority: Normal * Assignee: * Target version: * ruby -v: * Backport: 2.2: DONTNEED, 2.3: DONTNEED, 2.4: DONE ---------------------------------------- When editing string.c and execute `make run`, below warnings showed. ``` $ make run ../ruby/string.c:6142:41: warning: '&&' within '||' [-Wlogical-op-parentheses] ...(flags&ONIGENC_CASE_ASCII_ONLY) && (enc==rb_utf8_encoding() || rb_enc_mbmaxlen(enc)==1) ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../ruby/string.c:6142:41: note: place parentheses around the '&&' expression to silence this warning ...(flags&ONIGENC_CASE_ASCII_ONLY) && (enc==rb_utf8_encoding() || rb_enc_mbmaxlen(enc)==1) ^ ( ) ../ruby/string.c:6208:41: warning: '&&' within '||' [-Wlogical-op-parentheses] ...(flags&ONIGENC_CASE_ASCII_ONLY) && (enc==rb_utf8_encoding() || rb_enc_mbmaxlen(enc)==1) ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../ruby/string.c:6208:41: note: place parentheses around the '&&' expression to silence this warning ...(flags&ONIGENC_CASE_ASCII_ONLY) && (enc==rb_utf8_encoding() || rb_enc_mbmaxlen(enc)==1) ^ ( ) ``` I fixed this warnings using note. in Github: https://github.com/ruby/ruby/pull/1570 -- https://bugs.ruby-lang.org/ Unsubscribe: