From: ko1@... Date: 2017-05-19T02:24:23+00:00 Subject: [ruby-core:81235] [Ruby trunk Feature#13552][Assigned] [PATCH 0/2] reimplement ConditionVariable, Queue, SizedQueue using ccan/list Issue #13552 has been updated by ko1 (Koichi Sasada). Status changed from Open to Assigned Assignee set to normalperson (Eric Wong) Target version set to 2.5 Sorry for late response. Only one comment (maybe you passes all of tests, right?) New data type should be RUBY_TYPED_WB_PROTECTED (they need to use write barriers correctly). Do you want to try or should I modify? Thanks, Koichi ---------------------------------------- Feature #13552: [PATCH 0/2] reimplement ConditionVariable, Queue, SizedQueue using ccan/list https://bugs.ruby-lang.org/issues/13552#change-64891 * Author: normalperson (Eric Wong) * Status: Assigned * Priority: Normal * Assignee: normalperson (Eric Wong) * Target version: 2.5 ---------------------------------------- ``` The performance improvement increases as the number of waiters increases, due to avoiding the O(n) behavior of rb_ary_delete on the waiting thread. Uncontended queues and condition variables performance is not altered significantly. Function entry cost is slightly increased for ConditionVariable, since the data pointer is separately allocated and not embedded into the RVALUE slot. name |trunk |built ----------------------|------:|------: vm_thread_condvar1 | 0.858| 0.858 vm_thread_condvar2 | 1.003| 0.804 vm_thread_queue | 0.131| 0.129 vm_thread_sized_queue | 0.265| 0.251 vm_thread_sized_queue2| 0.892| 0.859 vm_thread_sized_queue3| 0.879| 0.845 vm_thread_sized_queue4| 0.599| 0.486 Speedup ratio: compare with the result of `trunk' (greater is better) name |built ----------------------|------: vm_thread_condvar1 | 0.999 vm_thread_condvar2 | 1.246 vm_thread_queue | 1.020 vm_thread_sized_queue | 1.057 vm_thread_sized_queue2| 1.039 vm_thread_sized_queue3| 1.041 vm_thread_sized_queue4| 1.233 ``` ---Files-------------------------------- 0001-thread_sync.c-rename-mutex_waiter-struct-to-sync_wai.patch (1.63 KB) 0002-thread_sync.c-rewrite-the-rest-using-using-ccan-list.patch (21.3 KB) -- https://bugs.ruby-lang.org/ Unsubscribe: