From: ko1@... Date: 2017-05-05T00:16:21+00:00 Subject: [ruby-core:81001] [Ruby trunk Misc#13541] [PATCH] test/thread: relax checks for internal implementation Issue #13541 has been updated by ko1 (Koichi Sasada). It seems no problem. I think you can write that this change is related to "error message" in commit log (dependencies caused by error message). Because I can't imagine these dependencies with your report (this ticket) before I check your patch. Thanks, Koichi ---------------------------------------- Misc #13541: [PATCH] test/thread: relax checks for internal implementation https://bugs.ruby-lang.org/issues/13541#change-64661 * Author: normalperson (Eric Wong) * Status: Open * Priority: Normal * Assignee: ---------------------------------------- Queue, SizedQueue, and ConditionVariable internal implementation should not be tied to using arrays. Implementation details can change and I am working on a change to remove the dependency on arrays (as others may attempt, too) by using ccan/list for the waiter list. * test/thread/test_cv.rb (test_dump): remove check for Array * test/thread/test_queue.rb (test_dump): ditto I have no idea if my work-in-progress change to use ccan/list will be acceptable; regardless, I do not believe we should be testing for this implementation detail. Will commit in a few days if no objections. ---Files-------------------------------- 0001-test-thread-relax-checks-for-internal-implementation.patch (1.46 KB) -- https://bugs.ruby-lang.org/ Unsubscribe: