From: Eric Wong <normalperson@...>
Date: 2017-05-03T02:52:13+00:00
Subject: [ruby-core:80982] Re: [Ruby trunk Bug#13519] Improve performance of some Time methods

watson1978@gmail.com wrote:
> Bug #13519: Improve performance of some Time methods
> https://bugs.ruby-lang.org/issues/13519

> Some Time methods will call internal quov() function and
> quov() calls Numeric#quo -> Rational#quo -> ...
> 
> This patch will add rb_numeric_quo() as internal C API to call Numeric#quo directly.
> And this will use rb_numeric_quo() instead of rb_funcall() for Numeric#quo to internal objects.

I guess this is OK...

I notice this change; along with many similar optimizations in
time.c such as r54218, r54203, ... do not check method
redefinition flags on Integer.

Are we OK with this? (I am)

I guess 2.4 was released with some of these changes;
and nobody complained so far...

Can we disable/disallow redefinition of more methods? :)

Unsubscribe: <mailto:ruby-core-request@ruby-lang.org?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>