From: nobu@... Date: 2017-04-13T08:45:49+00:00 Subject: [ruby-core:80677] [Ruby trunk Bug#13428][Rejected] rbinstall should not use Spec#files anymore Issue #13428 has been updated by nobu (Nobuyoshi Nakada). Status changed from Open to Rejected It's used only for default gems, `spec.files` are for separated gem releases, but just garbage there. ---------------------------------------- Bug #13428: rbinstall should not use Spec#files anymore https://bugs.ruby-lang.org/issues/13428#change-64210 * Author: vo.x (Vit Ondruch) * Status: Rejected * Priority: Normal * Assignee: nobu (Nobuyoshi Nakada) * Target version: * ruby -v: ruby 2.5.0dev (2017-04-11 trunk 58327) [x86_64-linux] * Backport: 2.2: UNKNOWN, 2.3: UNKNOWN, 2.4: UNKNOWN ---------------------------------------- I'd like to clarify this line [1]. Just two days ago, it was removed by my PR [2] in r58317 and now it is back in r58327. Is this just mistake? If the gem is listed in gems/bundled_gems, the gem is downloaded from RubyGems, expanded and the .gemspec [3] is containing list of the files originally shipped in the .gem package (this is actually wrong, since the gem might ship its own .gemspec file and this one rewrites the original one and later the installation contains this non-original file, but this is different story). In case of default gems, neither here is the file list needed since my PR [4] merged in r58317. So I am wondering under what other circumstances is the line [1] needed? For what purpose it returned to the codebase? [1]: https://github.com/ruby/ruby/blob/trunk/tool/rbinstall.rb#L794 [2]: https://github.com/ruby/ruby/pull/1579/ [3]: https://github.com/ruby/ruby/blob/trunk/tool/gem-unpack.rb#L15 [4]: https://github.com/ruby/ruby/pull/1578 -- https://bugs.ruby-lang.org/ Unsubscribe: