[#80531] Re: [ruby-cvs:65407] normal:r58236 (trunk): thread.c: comments on M:N threading [ci skip] — Eric Wong <normalperson@...>
SASADA Koichi <ko1@ruby-lang.org> wrote:
On 2017/04/02 11:35, Eric Wong wrote:
SASADA Koichi <ko1@atdot.net> wrote:
Eric Wong <normalperson@yhbt.net> wrote:
On 2017/05/08 9:33, Eric Wong wrote:
On 2017/05/08 10:53, SASADA Koichi wrote:
SASADA Koichi <ko1@atdot.net> wrote:
On 2017/05/08 12:01, Eric Wong wrote:
SASADA Koichi <ko1@atdot.net> wrote:
On 2017/05/08 15:36, Eric Wong wrote:
SASADA Koichi <ko1@atdot.net> wrote:
On 2017/05/09 12:38, Eric Wong wrote:
SASADA Koichi <ko1@atdot.net> wrote:
On 2017/05/09 14:12, Eric Wong wrote:
SASADA Koichi <ko1@atdot.net> wrote:
On 2017/05/09 15:23, Eric Wong wrote:
SASADA Koichi <ko1@atdot.net> wrote:
Thank you.
[#80763] [Ruby trunk Feature#13434] better method definition in C API — naruse@...
Issue #13434 has been updated by naruse (Yui NARUSE).
[#80844] [Ruby trunk Bug#13503] Improve performance of some Time & Rational methods — watson1978@...
Issue #13503 has been updated by watson1978 (Shizuo Fujita).
[#80892] [Ruby trunk Misc#13514] [PATCH] thread_pthread.c (native_sleep): preserve old unblock function — ko1@...
Issue #13514 has been updated by ko1 (Koichi Sasada).
ko1@atdot.net wrote:
On 2017/04/27 8:58, Eric Wong wrote:
SASADA Koichi <ko1@atdot.net> wrote:
Eric Wong <normalperson@yhbt.net> wrote:
[ruby-core:80827] [Ruby trunk Bug#13491][Closed] MinGW 58400 - TestSocket_BasicSocket#test_read_write_nonblock
Issue #13491 has been updated by usa (Usaku NAKAMURA).
Status changed from Open to Closed
I got same error, too.
And it seems that r58437 has fixed it.
I still doubt that there is something wrong with `IO#read_nonblock` on Windows, but, about this issue, can be closed.
----------------------------------------
Bug #13491: MinGW 58400 - TestSocket_BasicSocket#test_read_write_nonblock
https://bugs.ruby-lang.org/issues/13491#change-64432
* Author: MSP-Greg (Greg L)
* Status: Closed
* Priority: Normal
* Assignee:
* Target version:
* ruby -v: ruby 2.5.0dev (2017-04-21 trunk 58426) [x64-mingw32]
* Backport: 2.2: UNKNOWN, 2.3: UNKNOWN, 2.4: UNKNOWN
----------------------------------------
The test `TestSocket_BasicSocket#test_read_write_nonblock` was recently add via [58400](https://bugs.ruby-lang.org/projects/ruby-trunk/repository/revisions/58400/diff) / [c32fc82](https://github.com/ruby/ruby/commit/c32fc82d0ed8bcf0d6e4de8518bbb7bd808a69b8).
On a MinGW build, it fails. The following change [at line 197](https://github.com/ruby/ruby/blob/c32fc82d0ed8bcf0d6e4de8518bbb7bd808a69b8/test/socket/test_basicsocket.rb#L197) allows a MinGW build to pass.
```ruby
case r = ssock.read_nonblock(16384, buf, exception: false)
when String
next
when nil
break
else
- flunk "unexpected read_nonblock return: #{r.inspect}"
+ flunk "unexpected read_nonblock return: #{r.inspect}" unless set_nb
end while true
```
See [GitHub PR 1595](https://github.com/ruby/ruby/pull/1595)
--
https://bugs.ruby-lang.org/
Unsubscribe: <mailto:ruby-core-request@ruby-lang.org?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>