From: v.ondruch@... Date: 2017-04-12T18:48:29+00:00 Subject: [ruby-core:80671] [Ruby trunk Bug#13427] gemspec might be treat as binary - probably bug? Issue #13427 has been updated by vo.x (Vit Ondruch). Hanmac (Hans Mackowiak) wrote: > there is a open ticket in the repo of rubygems opend in "14 Apr 2014" but it is unanswerd since months. True ... > also i see that rubygems also did many ".freeze" into the files while "# frozen_string_literal: true" should probably used. > that might not be done jet because ruby 2.2 is still in "security maintenance phase"? RubyGems still supports even Ruby 1.8.7 if I am not mistaken: https://github.com/rubygems/rubygems/blob/master/.travis.yml ---------------------------------------- Bug #13427: gemspec might be treat as binary - probably bug? https://bugs.ruby-lang.org/issues/13427#change-64199 * Author: Hanmac (Hans Mackowiak) * Status: Open * Priority: Normal * Assignee: * Target version: * ruby -v: * Backport: 2.2: UNKNOWN, 2.3: UNKNOWN, 2.4: UNKNOWN ---------------------------------------- while getting latest ruby sources i noticed that json.gemspec is treated as binary by git. and while looking why that is, i noticed that the gemspec for some reason "\0" is inside the file, which causes text programms to think its a binary file instead of a text file. to checkout why that happens, it seems that rubygems itself did add the "\0" into the file which seems to be wrong. there is a open ticket in the repo of rubygems opend in "14 Apr 2014" but it is unanswerd since months. also i see that rubygems also did many ".freeze" into the files while "# frozen_string_literal: true" should probably used. that might not be done jet because ruby 2.2 is still in "security maintenance phase"? links: https://github.com/rubygems/rubygems/issues/883 https://github.com/flori/json/issues/310 (unanswerd) -- https://bugs.ruby-lang.org/ Unsubscribe: