[ruby-core:80825] [Ruby trunk Bug#13491] MinGW 58400 - TestSocket_BasicSocket#test_read_write_nonblock

Issue #13491 has been updated by MSP-Greg (Greg L).


normalperson (Eric Wong) wrote:
> Can you try r58437?

Works.  I guess I was staring at the case statement, I should have added the test for `:wait_readable`.  I tried `IO.select`, but I left of the timeout...

Thank you.  I'll close the PR and this can be closed.

----------------------------------------
Bug #13491: MinGW 58400 - TestSocket_BasicSocket#test_read_write_nonblock
https://bugs.ruby-lang.org/issues/13491#change-64430

* Author: MSP-Greg (Greg L)
* Status: Open
* Priority: Normal
* Assignee: 
* Target version: 
* ruby -v: ruby 2.5.0dev (2017-04-21 trunk 58426) [x64-mingw32]
* Backport: 2.2: UNKNOWN, 2.3: UNKNOWN, 2.4: UNKNOWN
----------------------------------------
The test `TestSocket_BasicSocket#test_read_write_nonblock` was recently add via [58400](https://bugs.ruby-lang.org/projects/ruby-trunk/repository/revisions/58400/diff) / [c32fc82](https://github.com/ruby/ruby/commit/c32fc82d0ed8bcf0d6e4de8518bbb7bd808a69b8).

On a MinGW build, it fails.  The following change [at line 197](https://github.com/ruby/ruby/blob/c32fc82d0ed8bcf0d6e4de8518bbb7bd808a69b8/test/socket/test_basicsocket.rb#L197) allows a MinGW build to pass.

```ruby
      case r = ssock.read_nonblock(16384, buf, exception: false)
      when String
        next
      when nil
        break
      else
-       flunk "unexpected read_nonblock return: #{r.inspect}"
+       flunk "unexpected read_nonblock return: #{r.inspect}" unless set_nb
      end while true
```

See [GitHub PR 1595](https://github.com/ruby/ruby/pull/1595)




-- 
https://bugs.ruby-lang.org/

Unsubscribe: <mailto:[e-mail]?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>