From: eregontp@... Date: 2017-04-25T12:10:23+00:00 Subject: [ruby-core:80860] [Ruby trunk Feature#12944] Change Kernel#warn to call Warning.warn Issue #12944 has been updated by Eregon (Benoit Daloze). File 0001-Restore-behavior-of-Kernel-warn-accepting-arrays-arg.patch added I attach a patch based on Jeremy "Use rb_ary_join" patch, rebased to current trunk. I think using args.join("\n") is a good way to restore the needed compatibility as shown above and yet simple enough. It's also what I intuitively used when redefining Kernel#warn in Ruby. It fixes the wrong output for the Thread.exclusive warning, allows ruby/spec to no longer have different tests for 2.5's #warn and sends a single String to Warning.warn for proper filtering. Can I commit this patch? ---------------------------------------- Feature #12944: Change Kernel#warn to call Warning.warn https://bugs.ruby-lang.org/issues/12944#change-64466 * Author: jeremyevans0 (Jeremy Evans) * Status: Closed * Priority: Normal * Assignee: * Target version: ---------------------------------------- Currently, Kernel#warn is basically the same as $stderr.puts. With the new Warning.warn support in ruby 2.4, it makes sense for Kernel#warn to call Warning.warn, otherwise you will not be able to use Warning.warn to filter/process warning messages generated by Kernel#warn. The Kernel#warn API is different than the Warning.warn API, the attached patch tries to get similar behavior, but there are probably corner cases where the behavior is different. ---Files-------------------------------- 0001-Change-Kernel-warn-to-call-Warning.warn.patch (1.88 KB) 0001-Change-Kernel-warn-to-call-Warning.warn.patch (1.89 KB) 0001-Change-Kernel-warn-to-call-Warning.warn.patch (2.36 KB) 0001-Change-Kernel-warn-to-call-Warning.warn.patch (2.3 KB) 0001-Change-Kernel-warn-to-call-Warning.warn.patch (3.23 KB) 0001-Restore-behavior-of-Kernel-warn-accepting-arrays-arg.patch (1.23 KB) -- https://bugs.ruby-lang.org/ Unsubscribe: