From: Eric Wong Date: 2020-07-16T00:04:01+00:00 Subject: [ruby-core:99186] Re: [Ruby master Bug#17023] How to prevent String memory to be relocated in ruby-ffi Aaron Patterson wrote: > > On Jul 15, 2020, at 4:35 PM, Eric Wong wrote: > > Btw, does rb_gc_register_mark_object pin? A quick glance at > > gc.c tells me it doesn't, and I'll need to revert commit > > 2a6cb76d5010cb763ef5a2c305728465d15eb7c9 in unicorn: > > https://yhbt.net/unicorn-public/20181226050857.6413-1-e@80x24.org/ > > Yes, it does pin. I���m not super proud of this code, but here > is where objects passed to rb_gc_register_mark_object get > pinned: > > https://github.com/ruby/ruby/blob/c2a6295ec04a191c689d22254ac1ad5d665e27ad/vm.c#L2307-L2320 Ah, missed that, thanks. So all is well in unicorn (for now). > I don���t know why the mark object array is an array of arrays > (I assume so as not to waste space in the array buffer?). > Maybe this could be a more friendly data structure. It seems so, since rb_ary_push can double the internal buffer. Anyways, ko1 made commit a617afc643e17cea5c1960a60adcd5ffb25fdfe2 r46714 Maybe it can be flattened nowadays and rely on GC.compact to reclaim unused space. /me goes back to hacking in Perl 5... Unsubscribe: