[ruby-core:65004] Re: [ruby-trunk - Bug #10231] Process.detach(pid) defines new singleton classes every call

From: Eric Wong <normalperson@...>
Date: 2014-09-12 20:37:00 UTC
List: ruby-core #65004
headius@headius.com wrote:
> Eric Wong wrote:
> > I haven't checked the inits.c ordering change closely, but
> >  make check and test-rubyspec passes:
> 
> +1 This is how I'd fix it.

Committed with nobu's comments as r47561
Process.detach: avoid singleton class creation

A NEWS entry may be appropriate as well.

I prefer deliberately leaving out Process::Waiter and Thread references,
since I think we may be able to avoid Thread creation entirely in the
future (not sure if it's worth the effort).

--- a/NEWS
+++ b/NEWS
@@ -113,6 +113,8 @@ with all sufficient information, see the ChangeLog file.
   * Process execution methods such as Process.spawn opens the file in write
     mode for redirect from [:out, :err].
     Before Ruby 2.2, it was opened in read mode.
+  * Process.detach returns the same object class instead of creating a
+    new singleton class every call.
 
 === Stdlib updates (outstanding ones only)
 

In This Thread

Prev Next