From: headius@...
Date: 2014-09-12T13:46:03+00:00
Subject: [ruby-core:64999] [ruby-trunk - Bug #10231] Process.detach(pid) defines new singleton classes every call

Issue #10231 has been updated by Charles Nutter.


Eric Wong wrote:
> I haven't checked the inits.c ordering change closely, but
>  make check and test-rubyspec passes:

+1 This is how I'd fix it.

----------------------------------------
Bug #10231: Process.detach(pid) defines new singleton classes every call
https://bugs.ruby-lang.org/issues/10231#change-48874

* Author: Charles Nutter
* Status: Open
* Priority: Normal
* Assignee: 
* Category: 
* Target version: 
* ruby -v: Any version with Process.detach
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN
----------------------------------------
The logic for Process.detach(pid) adds a singleton "pid" method to the thread it returns for every call. This is bad for method caches (MRI still flushes them all for this, I believe) and memory churn (singleton classes are not small).

The offending line of code is here: https://github.com/ruby/ruby/blob/trunk/process.c#L1041

I would suggest that Process.detach should return a subclass of Thread that has the pid method defined ahead of time.

It also stores the value in thread local storage, rather than as an instance variable. I'm not sure why.



-- 
https://bugs.ruby-lang.org/