From: "sunaku (Suraj Kurapati)" <sunaku@...>
Date: 2013-02-13T23:28:34+09:00
Subject: [ruby-core:52213] [ruby-trunk - Feature #2294] [PATCH] ruby_bind_stack() to embed Ruby in coroutine


Issue #2294 has been updated by sunaku (Suraj Kurapati).


Hi,

ko1 (Koichi Sasada) wrote:
>
>  (2013/02/13 14:49), sunaku (Suraj Kurapati) wrote:
>  > Ruby must also be bound to the coroutine's stack address range.
>
>  I think you got misunderstanding.
>
>  (1) Ruby interpreter must know machine stack start, not a `range'.
>  (2) Machine stack start can be grabbed without telling an address
>      range explicitly.
>      See a r38905.
>
>  NOTE: On Ruby 1.8, may run fine on co-routines.
>        The patch revert to this behavior.
>
>  Without machine-stack-end, we can't detect machine stack
>  overflow. This is an issue. But not a critical issue.
>
>  However, the implantation of `ruby_bind_stack()' has several
>  problems:
>
>  - Designed on misunderstanding
>  - Depend on specific architecture

Ah, I finally understand now.  Thank you for explaining! :-)

>  I agree to add another interface to tell the stack range. But
>  `ruby_bind_stack()' is not acceptable now. At least Ruby 2.0.0
>  shouldn't include it.
>
>  Maybe it will be a parameter of an initialize function of the
>  Ruby interpreter.

Very well; that is reasonable.  I agree with your decision.

>  > Ruby might go beyond the coroutine's pre-allocated stack
>  > address range.
>
>  Yes. That's right.

I'm glad to have the same understanding in this aspect.

>  >>> 2.  In my coroutine example, only ucontext works correctly:
>
>  I believe last patch will solve this issue.
>  So the problem is based on my misunderstanding or a bug.
>  I want to solve this issue before 2.0.0 release.
>
>  I'll check it soon.

Certainly; I will wait for your response.

Please tell me if I can be of assistance.
----------------------------------------
Feature #2294: [PATCH] ruby_bind_stack() to embed Ruby in coroutine
https://bugs.ruby-lang.org/issues/2294#change-36236

Author: sunaku (Suraj Kurapati)
Status: Assigned
Priority: High
Assignee: ko1 (Koichi Sasada)
Category: core
Target version: 2.0.0


=begin
 Hi,
 
 I am attaching a "ruby_bind_stack.patch" patch file 
 that adds a ruby_bind_stack() function to the Ruby C API.
 
 This function allows me to inform the GC about the stack
 boundaries of the coroutine inside which Ruby is embedded:
 
   void ruby_bind_stack(void *lower, void *upper);
 
 I am also attaching tarballs containing code examples that
 embed Ruby inside two different coroutine environments:
 UNIX System V contexts[1] and libpcl[2] coroutines.
 
 Each tarball has an "output.log" file which contains the
 result of running `script -c ./run.sh output.log` on my
 machine:
 
 Linux yantram 2.6.31-ARCH #1 SMP PREEMPT Tue Oct 13 13:36:23 CEST 2009 i686 Intel(R) Pentium(R) D CPU 3.00GHz GenuineIntel GNU/Linux
 
 The last section in "output.log" corresponds to Ruby @ SVN
 trunk that is patched with the "ruby_bind_stack.patch" 
 patch file that is attached to this issue.
 
 Thanks for your consideration.
 
 [1]: http://www.gnu.org/s/libc/manual/html_node/System-V-contexts.html
 [2]: http://www.xmailserver.org/libpcl.html
 
 See also:
 * http://redmine.ruby-lang.org/issues/show/2258
 * http://redmine.ruby-lang.org/issues/show/2126
=end



-- 
http://bugs.ruby-lang.org/