From: "zzak (Zachary Scott)" <zachary@...>
Date: 2013-04-20T05:44:03+09:00
Subject: [ruby-core:54470] [ruby-trunk - Bug #7940] Mistaken use of inline rescues in stdlib


Issue #7940 has been updated by zzak (Zachary Scott).


I've tweeted @david_a_black asking him to check this ticket.

He has been inactive for a long time, though.
----------------------------------------
Bug #7940: Mistaken use of inline rescues in stdlib
https://bugs.ruby-lang.org/issues/7940#change-38775

Author: Mon_Ouie (Mon ou��e)
Status: Assigned
Priority: Normal
Assignee: dblack (David Black)
Category: lib
Target version: current: 2.1.0
ruby -v: ruby 1.9.3p392 (2013-02-22 revision 39386) [x86_64-linux]
Backport: 


Hey,

There are two uses of inline rescues in stdlib that look dubious. They are unlikely to ever cause any harm, but still. They've been there for a while now, and are still in trunk. I attached a patch that changes both of them.

In cgi/session.rb:

      def delete
        File::unlink @path+".lock" rescue nil
        File::unlink @path+".new" rescue nil
        File::unlink @path rescue Errno::ENOENT
      end

The ``rescue`` part should be on the next line (this has been introduced in a commit that changed indentation).

In scanf.rb:660:

   seek(start_position + matched_so_far, IO::SEEK_SET) rescue Errno::ESPIPE

was more likely meant to just silence Errno::ESPIPE exceptions.


-- 
http://bugs.ruby-lang.org/